Date: Wed, 26 Jun 2024 16:11:07 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl> Cc: Gleb Smirnoff <glebius@freebsd.org>, Ed Maste <emaste@freebsd.org>, FreeBSD Net <freebsd-net@freebsd.org> Subject: Re: ICMP6 Message-ID: <ACFEFE2D-90BD-4950-A3A8-95699D2C5F86@FreeBSD.org> In-Reply-To: <1e78e57a-1748-4fec-8071-db7a1b0ec7e8@plan-b.pwste.edu.pl> References: <972cd3b3-e64a-46e6-a8ea-1bdd6ab7033e@plan-b.pwste.edu.pl> <C83BFAA8-48C3-4501-81D7-9E903CFF048F@FreeBSD.org> <ZmXt1xqK4CizzkH-@cell.glebi.us> <523F3ED6-3E44-4ADA-9534-64735BC60804@FreeBSD.org> <1e78e57a-1748-4fec-8071-db7a1b0ec7e8@plan-b.pwste.edu.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_47E0CD15-68F3-4A1B-824A-6D238A86843C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Jun 26, 2024, at 2:24 PM, Marek Zarychta = <zarychtam@plan-b.pwste.edu.pl> wrote: >=20 > W dniu 26.06.2024 o 06:55, Zhenlei Huang pisze: >>=20 >> The MFC is Done ! >>=20 >> Marek has extensive testing with them. I did stress testing on my dev = machine. No known issues so far. > Thank you very much for the MFC of the commits set I suggested. I have = been testing these changes for several weeks on 10+ various hosts, = including servers and routers, and I only see positive changes. I hope = that no important commit was omitted in selecting the set for this MFC = and there will be no complaints.=20 >=20 > The only thing I would suggest is to change in future the default = value of net.inet6.icmp6.errppslimit to 200. It will be the same value = as defaults for net.inet.icmp.icmplim. In my case it was required to = silence spurious warnings on two web servers and BGP router.=20 >=20 The value 100 of tunable `net.inet6.icmp6.errppslimit` dates back to = 2000, the first time it was introduced [1]. I do not find any RFCs that has recommendation value for it. RFC 4443 = section 2.4 (f) [2] has an example default of 10 that is much smaller ( for small/mid-size devices ). I expect the default value of net.inet6.icmp6.errppslimit will stay 100 = for much longer time ;) 1. = https://cgit.freebsd.org/src/commit/sys/netinet6/in6_proto.c?h=3Dstable/7&= id=3D686cdd19b1b182f2257bc158116e78c5fef84980=20 2. https://www.rfc-editor.org/rfc/rfc4443.html#section-2.4 Best regards, Zhenlei > With best regards, >=20 > --=20 > Marek Zarychta --Apple-Mail=_47E0CD15-68F3-4A1B-824A-6D238A86843C Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dus-ascii"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On Jun 26, 2024, at 2:24 PM, Marek Zarychta <<a = href=3D"mailto:zarychtam@plan-b.pwste.edu.pl" = class=3D"">zarychtam@plan-b.pwste.edu.pl</a>> wrote:</div><br = class=3D"Apple-interchange-newline"><div class=3D""> =20 <meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3DUTF-8" class=3D""> =20 <div class=3D""> <div class=3D"moz-cite-prefix">W dniu 26.06.2024 o 06:55, = Zhenlei Huang pisze:<br class=3D""> </div> <blockquote type=3D"cite" = cite=3D"mid:523F3ED6-3E44-4ADA-9534-64735BC60804@FreeBSD.org" = class=3D""><span style=3D"white-space: pre-wrap" class=3D""> </span> <pre class=3D"moz-quote-pre" wrap=3D"">The MFC is Done ! Marek has extensive testing with them. I did stress testing on my dev = machine. No known issues so far. </pre> </blockquote><p class=3D""><span class=3D"HwtZe" lang=3D"en"><span = class=3D"jCAhz JxVs2d ChMk0b"><span class=3D"ryNqvb">Thank you very much = for the MFC of the commits set I suggested.</span></span> <span class=3D"jCAhz = JxVs2d ChMk0b"><span class=3D"ryNqvb">I have been testing these changes for several weeks on = 10+</span></span></span><span class=3D"HwtZe" lang=3D"en"><span = class=3D"jCAhz JxVs2d ChMk0b"><span class=3D"ryNqvb"> various hosts, = including servers and routers</span></span></span><span class=3D"HwtZe" = lang=3D"en"><span class=3D"jCAhz JxVs2d ChMk0b"><span class=3D"ryNqvb">, = and I only see positive changes.</span></span> <span class=3D"jCAhz JxVs2d ChMk0b"><span class=3D"ryNqvb">I = hope that no important commit was omitted in selecting the set for this MFC and there will be no complaints.</span></span> <span class=3D"jCAhz JxVs2d ChMk0b"><span class=3D"ryNqvb"><br = class=3D""> </span></span></span></p><p class=3D""><span class=3D"HwtZe" = lang=3D"en"><span class=3D"jCAhz JxVs2d ChMk0b"><span class=3D"ryNqvb">The= only thing I would suggest is to change in future the default value of net.inet6.icmp6.errppslimit to 200. It </span></span></span><span class=3D"HwtZe" = lang=3D"en"><span class=3D"jCAhz JxVs2d ChMk0b"><span = class=3D"ryNqvb">will be the same value as defaults for net.inet.icmp.icmplim. In my case it was required to silence spurious warnings on two web servers and BGP router. <br = class=3D""></span></span></span></p></div></div></blockquote><div>The = value 100 of tunable `net.inet6.icmp6.errppslimit` dates back to 2000, = the first time it was introduced [1].</div><div><br = class=3D""></div><div>I do not find any RFCs that has recommendation = value for it. RFC 4443 section 2.4 (f) [2] has an example default of 10 = that</div><div>is much smaller ( for small/mid-size devices = ).</div><div><br class=3D""></div><div>I expect the default value = of <span style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);" = class=3D"">net.inet6.icmp6.errppslimit will stay 100 for much longer = time ;)</span></div><div><br class=3D""></div><div><br = class=3D""></div><div>1. <a = href=3D"https://cgit.freebsd.org/src/commit/sys/netinet6/in6_proto.c?h=3Ds= table/7&id=3D686cdd19b1b182f2257bc158116e78c5fef84980" = class=3D"">https://cgit.freebsd.org/src/commit/sys/netinet6/in6_proto.c?h=3D= stable/7&id=3D686cdd19b1b182f2257bc158116e78c5fef84980</a> </div>= <div>2. <a = href=3D"https://www.rfc-editor.org/rfc/rfc4443.html#section-2.4" = class=3D"">https://www.rfc-editor.org/rfc/rfc4443.html#section-2.4</a></di= v><div><br class=3D""></div><div style=3D"caret-color: rgb(0, 0, 0); = color: rgb(0, 0, 0);">Best regards,</div><div style=3D"caret-color: = rgb(0, 0, 0); color: rgb(0, 0, 0);">Zhenlei</div><blockquote type=3D"cite"= class=3D""><div class=3D""><div class=3D""><p class=3D""><span = class=3D"HwtZe" lang=3D"en"><span class=3D"jCAhz JxVs2d ChMk0b"><span = class=3D"ryNqvb"> </span></span></span></p><p class=3D"">With best regards,<br = class=3D""> </p> <pre class=3D"moz-signature" cols=3D"72">--=20 Marek Zarychta</pre> </div> </div></blockquote></div><br class=3D""><div class=3D""> <div><br class=3D""></div> </div> <br class=3D""></body></html>= --Apple-Mail=_47E0CD15-68F3-4A1B-824A-6D238A86843C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ACFEFE2D-90BD-4950-A3A8-95699D2C5F86>