From owner-freebsd-current@FreeBSD.ORG Wed Nov 3 21:31:35 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6506E1065679; Wed, 3 Nov 2010 21:31:35 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 7A6578FC1E; Wed, 3 Nov 2010 21:31:34 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id XAA14538; Wed, 03 Nov 2010 23:31:22 +0200 (EET) (envelope-from avg@freebsd.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1PDkvS-000AtK-DG; Wed, 03 Nov 2010 23:31:22 +0200 Message-ID: <4CD1D4AA.3060309@freebsd.org> Date: Wed, 03 Nov 2010 23:31:22 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Alan Cox , freebsd-current@freebsd.org References: <4CA0DA49.2090006@freebsd.org> <4CA3A48A.5070300@freebsd.org> <4CA3BD1E.5070807@rice.edu> <4CA5911E.3000101@freebsd.org> <4CAE0060.7050607@freebsd.org> <4CAECC4D.90707@rice.edu> <4CD1AA45.7000504@freebsd.org> <4CD1AD80.2090903@rice.edu> In-Reply-To: <4CD1AD80.2090903@rice.edu> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Alan Cox Subject: Re: minidump size on amd64 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2010 21:31:35 -0000 So, here is the next version of the patch: http://people.freebsd.org/~avg/amd64-minidump.4.diff Changes since the last version: 1. libkvm - try to support both the new and the previous formats/versions of amd64 minidump. I am not entirely sure about style in which I handled handling of version 1 minidump. Identifier names like pmapsize (for "page map size") and page_map could also be improved, perhaps. 2. kernel - implemented dumping of 1GB pages via "fake" 512 x 2MB pages per Alan's suggestion. The change is only compile tested so far. Not sure if it's possible to test handling 1GB pages yet :-) As always, reviews, testing and suggestions are very welcome. Thank you for your help! -- Andriy Gapon