From owner-svn-src-all@freebsd.org Fri Feb 24 21:54:44 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36F42CEC80B for ; Fri, 24 Feb 2017 21:54:44 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0F32D1C8E for ; Fri, 24 Feb 2017 21:54:43 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: c983270d-fadb-11e6-b3c2-c9f38144898e X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id c983270d-fadb-11e6-b3c2-c9f38144898e; Fri, 24 Feb 2017 21:54:17 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v1OLsfwX004421; Fri, 24 Feb 2017 14:54:41 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1487973281.25520.51.camel@freebsd.org> Subject: Re: svn commit: r314189 - head/lib/libcam From: Ian Lepore To: "Ngie Cooper (yaneurabeya)" Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 24 Feb 2017 14:54:41 -0700 In-Reply-To: References: <201702240624.v1O6OdRr094467@repo.freebsd.org> <1487950593.25520.20.camel@freebsd.org> <769272AC-D30C-4C69-B4D3-9805B9FFC28D@gmail.com> <1487971068.25520.45.camel@freebsd.org> Content-Type: text/plain; charset="windows-1251" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 21:54:44 -0000 On Fri, 2017-02-24 at 13:28 -0800, Ngie Cooper (yaneurabeya) wrote: > > > > On Feb 24, 2017, at 13:17, Ian Lepore wrote: > … > > > > > Alright.  That answers everything except the actual important > > question. > >  So, again: > > > > What *real* benefit does this churn bring? > The benefits are: clarity in intent in the code and fixing dead > (always false or always true) branches. The point you brought up is > addressing the first goal. > Thanks, > -Ngie What I'masking has nothing to do with dead branches.  So, no real benefit then.   I'm agnostic about using bare 0 versus '\0' in a context where the type is char.  The type of '\0' in plain-C is exactly the same as the type of a bare 0 -- both are just integer constants. style(9) prefers the '\0' form, but style(9) also offers these words of wisdom: Stylistic changes (including whitespace changes) are hard on the source repository and are to be avoided without good reason. I sure hope we're not going to see a big round of 'svn blame'-ruining commits just to change 0 to '\0' throughout the repo. -- Ian