Date: Wed, 16 Sep 1998 11:12:24 -0700 From: Studded <Studded@dal.net> To: Adrian Penisoara <ady@warpnet.ro> Cc: freebsd-ports@FreeBSD.ORG Subject: Re: ports/7938: Pine Port Upgrade: from 4.02A to 4.03 Message-ID: <35FFFF88.3D06143D@dal.net> References: <Pine.BSF.3.96.980916184542.8125C-100000@ady.warpnet.ro>
next in thread | previous in thread | raw e-mail | index | archive | help
Adrian Penisoara wrote:
> > you missed. Please add
> > ${WRKSRC}/build
> > ${WRKSRC}/doc/mime.types
> > ${WRKSRC}/pine/init.c
> >
> > to your list of files for the second sed command.
>
> In no case in the second but in the first:
I'm not sure what this means.
> these are source/executable
> files -- if the sed command replaces the string in an incorrect place then
> bad things may happen; OTOH in the case of documentation files there isn't
> too much to worry about.
I agree that this can be a problem, however I checked things very
thoroughly before I suggested doing this. That's why I submitted
individual patches the first time.
> Although the hardcoded path occures in some comment sections I will
> include @@PREFIX@@ patches in the already existent patchfiles for them.
>
> And BTW, this raises another ideea: I can't find any mailcap/mime.types
> files in /etc, /usr/share or any other place. I think we should have them
> placed somewhere (initially I was thinking about /usr/local/etc but now
> that I checked out /usr/share/misc I believe /usr/local/share/misc is more
> apropiate -- meaning, of course, ${PREFIX}/share/misc). What do you think?
> And about that, I think FreeBSD should come with its own general
> mailcap/mime.types files -- these files are pretty much OS dependant,
> don't you think ? And there are many programs that might use them besides
> Pine (Netscape's Navigator/Communicator, Lynx, etc.)...
I don't know that much about mime actually, so I can't help you there.
The /share/ directory is for architecture-independent stuff, so I think
/usr/local/etc/ would be better personally. I have a strong feeling that
anything that is user frobabble should be installed by the port in
/usr/local/etc, but not everyone shares my view.
> > Also, in the sources there are two files that refer to
> > /usr/local/pine.conf, pine4.03/doc/tech-notes/background.html and
> > pine4.03/doc/tech-notes.txt. Personally I consider this a "bug" in the
> > source. If you are in contact with the developers you might want to
> > mention this.
>
> Unfortunately I'm not in contact with any of them (I only remember to
> have talked once to Mark Crispin about the "imap-uw"'s evolution)...
> I'd be glad to suggest the patches on the pine-info list.
Works for me, thanks. :)
> > It would be nice if you included something to the effect of
> >
> > diff -ur pine4/work/pine4.03/doc/pine.1 pine4-old/work/pine4.03/doc/pine.1
> > --- pine4/work/pine4.03/doc/pine.1 Tue Sep 15 15:57:46 1998
> > +++ pine4-old/work/pine4.03/doc/pine.1 Tue Sep 15 15:50:57 1998
> > @@ -271,8 +271,6 @@
> > .br
> > /etc/mime.types System-wide file ext. to MIME type mapping
> > .br
> > -/usr/local/etc/mime.types Optional system-wide file ext. to MIME type
> > mapping
> > -.br
> > /usr/local/etc/pine.info Local pointer to system administrator.
> > .br
> > /usr/local/etc/pine.conf System-wide configuration file.
>
> (you switched the filenames on diff's command line)
I know, I was in a hurry and figured you'd know what I meant. :)
> > Finally, this part of the post-install target
> >
> > ${PREFIX}/bin/pine -P ${PREFIX}/etc/pine.conf -conf
> > >${WRKSRC}/pine.conf
> > ${INSTALL_DATA} ${WRKSRC}/pine.conf ${PREFIX}/etc/pine.conf
> >
> > indicates to me that you are trying to draw in the existing
> > /usr/local/etc/pine.conf file and combine that with the new conf file. My
> > testing indicates that this is not the case, and will result in
> > overwriting the user's pine.conf file. I still think that my solution to
> > this problem is better, but I'm biased. :)
>
> OK, it does look a bit weird but all I wanted to do is to upgrade the
> system wide ${PREFIX}/etc/pine.conf file (or install a fresh file if there
> isn't one already). This should be the replica of what Pine is going to do
> with the user's ~/.pinerc file on the first run :-) ...
> Do you see any problems with this ?
Sorry if I wasn't clear. I understand your intentions, but what you're
trying to do here won't work, it overwrites the system file with a blank
one. This is why I suggested installing the new one side-by-side with
the installed one of it already exists so the user could get a look at
the changes, etc. with diff.
> > I'm glad to see that you've taken my concerns to heart. I don't
> > want this to appear to be an adversarial undertaking, I think we both have
> > the same goal in mind, to make the best port possible.
>
> Exactly, and I can only thank you for helping me out :-) !
Glad to help.
Doug
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35FFFF88.3D06143D>