From owner-freebsd-net@FreeBSD.ORG Wed Feb 4 08:52:53 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 15EAE16A4CE for ; Wed, 4 Feb 2004 08:52:53 -0800 (PST) Received: from cheer.mahoroba.org (flets20-024.kamome.or.jp [218.45.20.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E9E443D1F for ; Wed, 4 Feb 2004 08:52:49 -0800 (PST) (envelope-from ume@FreeBSD.org) Received: from lyrics.mahoroba.org (IDENT:2cyjBjfg6i67K+AAA3J+e+R6IL0oqb6+Hi84Kx3rvy+ri9yFFgDAPghEY4Hbz9XH@lyrics.mahoroba.org [IPv6:3ffe:501:185b:8010:280:88ff:fe03:4841]) (user=ume mech=CRAM-MD5 bits=0)i14GqgZS097784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 5 Feb 2004 01:52:43 +0900 (JST) (envelope-from ume@FreeBSD.org) Date: Thu, 05 Feb 2004 01:52:42 +0900 Message-ID: From: Hajimu UMEMOTO To: Bruce Evans In-Reply-To: <20040204193623.E1469@gamplex.bde.org> References: <20040203183332.GD27244@Odin.AC.HMC.Edu> <20040204193623.E1469@gamplex.bde.org> User-Agent: xcite1.38> Wanderlust/2.11.3 (Wonderwall) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386--freebsd) MULE/5.0 (=?ISO-2022-JP?B?GyRCOC1MWhsoQg==?=) X-Operating-System: FreeBSD 5.2-CURRENT MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on cheer.mahoroba.org cc: net@freebsd.org Subject: Re: removing if_withname() X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Feb 2004 16:52:53 -0000 Hi, >>>>> On Wed, 4 Feb 2004 19:39:06 +1100 (EST) >>>>> Bruce Evans said: > Bruce pointed out that if_withname is inconsistent about IFNAMSIZ. I > was looking at it and cleaned it up, but then I realized that it is a > really inefficient implementation of ifnet_byindex(sdl->sdl_index). It > turns out that it's also completely unused so I'd like to remove it > entirely rather then fixing it since it's both broken and pointless. Is > there any reason not to do so? bde> It seems to be a pat of KAME that has never been used in FreeBSD bde> (net/if.c rev.1.77). Yes, once, it was introduced during 1st KAME merge, it is not used in current code in FreeBSD nor KAME. So, I believe it is safe to nuke it. Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/