Date: Wed, 27 Aug 2014 08:41:49 -0400 From: Glen Barber <gjb@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-doc-head@freebsd.org, svn-doc-all@freebsd.org, doc-committers@freebsd.org Subject: Re: svn commit: r45522 - head/share/xml Message-ID: <20140827124149.GI3131@hub.FreeBSD.org> In-Reply-To: <20140827.135956.2018605836230426826.hrs@allbsd.org> References: <201408262047.s7QKlHrv004804@svn.freebsd.org> <20140827.061828.245191660928093083.hrs@allbsd.org> <20140826212700.GE3131@hub.FreeBSD.org> <20140827.135956.2018605836230426826.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--jQIvE3yXcK9X9HBh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 27, 2014 at 01:59:56PM +0900, Hiroki Sato wrote: > Glen Barber <gjb@FreeBSD.org> wrote > in <20140826212700.GE3131@hub.FreeBSD.org>: >=20 > gj> On Wed, Aug 27, 2014 at 06:18:28AM +0900, Hiroki Sato wrote: > gj> > Glen Barber <gjb@FreeBSD.org> wrote > gj> > in <201408262047.s7QKlHrv004804@svn.freebsd.org>: > gj> > > gj> > gj> Author: gjb > gj> > gj> Date: Tue Aug 26 20:47:16 2014 > gj> > gj> New Revision: 45522 > gj> > gj> URL: http://svnweb.freebsd.org/changeset/doc/45522 > gj> > gj> > gj> > gj> Log: > gj> > gj> Add more missing manual pages from head/, stable/10/, and > gj> > gj> stable/9/ that were excluded from the previous change > gj> > gj> because of local make.conf(5) and src.conf(5) entries. > gj> > > gj> > gj> +<!ENTITY man.atf-c++-api.3 "<citerefentry xmlns=3D'http://docb= ook.org/ns/docbook'><refentrytitle>atf-c++-api</refentrytitle><manvolnum>3<= /manvolnum></citerefentry>"> > gj> > > gj> > An entity name needs to be in a [:_a-zA-Z][-.a-zA-Z0-9]* format in > gj> > US-ASCII. > gj> > > gj> > gj> Hmm, it passed my build test until I did 'make clean'. :( > gj> > gj> Fixed, sorry about the breakage. >=20 > No problem. You might want to fix the substitution in > share/exmaples/missing-manrefs.sh: >=20 It looks like it is share/examples/add-manref.sh that is getting the substitution incorrect. missing-manrefs.sh does not create the entity itself, it just runs add-manref.sh with the manual page and section. I'll take a look at it today. > gj> + _m=3D$(echo ${_m} | sed -e 's,\./,,') > gj> + _m=3D$(echo ${_m} | sed -e 's/_/./g') >=20 > And I think you should add a copyright notice into > missing-manrefs.sh. Without it, "... the above copyright notice ..." > in the two clauses do not make sense. >=20 Bah, not sure how that got removed from the file, thanks. Glen --jQIvE3yXcK9X9HBh Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJT/dINAAoJELls3eqvi17Qg6UP/R2NjoLge648VNKxcK35ZzuT Dd+K8se1Htj6MGlvO0czUzYIjcCoSmleHueH8eOwE092Fs+sLyThTZr5C9u2dXrK TpH382EU19ezUfCyxwgeOjr3QIwu6Y72FuoLtHwuamw+C0BEdWhDe/QQTnFe3qWs EwG4chPTHuEoMT8MToHhpu99gcyCZI/saBAckTA5b+RE9yUgRH7ymOgBlQXVE2jt Ya6Z5eohKJ1hBFYZ0XQtlR+vTS7LSCBBxZnPHQbopkNTEiP8QwO4E2fWEiN+nzDK RQSMYh1eAF33B8QVvhbEN3JQGYgaOVbtVeAaAL6xoGen8Huce+9q+ujGQVcbjize 8XH5Wn9I6U5Jv0ur1CvkZolOXiprNIzK4U861fINvhzgKSfFXRcPTNY6dBmCm85e aOnSMAazGzV5zWUEkyjIYrsxD48vxBccG7KIzdx9yUqJd96mSoTY7IkhlQ/USHRn uhyFy9zBo0G56Ca6nYr1hPq+xBuZpwQpflXVErKD493KINbUY7Khrp5R9qD0R1yH Xg7RLyHKDeFRUahsJfpt/HuS5diSd1ZI7OHE7J4AQg5oVuETmIccw56EiEZH9+Tg ctv0tMdp8q5sF33Gq4WlTZ3hwZBhf01YuznjB/sjFJFgPyYTXiUJYIlTqnyAzl7r dnMbHf0EzxD5G8qmQR/e =cDIj -----END PGP SIGNATURE----- --jQIvE3yXcK9X9HBh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140827124149.GI3131>