From owner-svn-src-all@freebsd.org Sun Jan 22 05:49:44 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE589CBC8E1; Sun, 22 Jan 2017 05:49:44 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ADD5EBEF; Sun, 22 Jan 2017 05:49:44 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v0M5nhLR045613; Sun, 22 Jan 2017 05:49:43 GMT (envelope-from jhibbits@FreeBSD.org) Received: (from jhibbits@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v0M5nhDf045612; Sun, 22 Jan 2017 05:49:43 GMT (envelope-from jhibbits@FreeBSD.org) Message-Id: <201701220549.v0M5nhDf045612@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jhibbits set sender to jhibbits@FreeBSD.org using -f From: Justin Hibbits Date: Sun, 22 Jan 2017 05:49:43 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r312613 - head/sys/powerpc/mpc85xx X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jan 2017 05:49:45 -0000 Author: jhibbits Date: Sun Jan 22 05:49:43 2017 New Revision: 312613 URL: https://svnweb.freebsd.org/changeset/base/312613 Log: Fix use of uninitialized variable. I don't know how gcc didn't catch this. This was caught during test building with clang. Modified: head/sys/powerpc/mpc85xx/fsl_diu.c Modified: head/sys/powerpc/mpc85xx/fsl_diu.c ============================================================================== --- head/sys/powerpc/mpc85xx/fsl_diu.c Sun Jan 22 05:45:42 2017 (r312612) +++ head/sys/powerpc/mpc85xx/fsl_diu.c Sun Jan 22 05:49:43 2017 (r312613) @@ -344,7 +344,7 @@ diu_init(struct diu_softc *sc) static int diu_attach(device_t dev) { - struct edid_info *edid; + struct edid_info edid; struct diu_softc *sc; const struct videomode *videomode; void *edid_cells; @@ -384,7 +384,7 @@ diu_attach(device_t dev) } } if (edid_cells != NULL) { - if (edid_parse(edid_cells, edid) != 0) { + if (edid_parse(edid_cells, &edid) != 0) { device_printf(dev, "Error parsing EDID\n"); OF_prop_free(edid_cells); return (ENXIO);