Date: Sun, 25 Jan 2009 20:19:00 GMT From: Randy Pratt <bsd-unix@embarqmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/130986: [PATCH] x11/xmore build failure Message-ID: <200901252019.n0PKJ0L9064994@www.freebsd.org> Resent-Message-ID: <200901252020.n0PKK18i017067@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 130986
>Category: ports
>Synopsis: [PATCH] x11/xmore build failure
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Jan 25 20:20:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Randy Pratt
>Release: FreeBSD-6.4
>Organization:
>Environment:
6.4-STABLE FreeBSD 6.4-STABLE #0: Wed Jan 14 08:00:33 EST 2009
>Description:
x11/xmore build failure during Xorg update:
===> Building for xmore-1.0.1_1
make all-am
cc -O -pipe -o xmore xmore-xmore.o -L/usr/local/lib -lXaw7 -lXmu -lXt -lX11 -lSM -lICE
xmore-xmore.o(.text+0x43): In function `printshellDestroyXtProc':
: undefined reference to `XawPrintDialogClosePrinterConnection'
*** Error code 1
Stop in /usr/ports/x11/xmore/work/xmore-1.0.1.
*** Error code 1
Some web searching turned up:
"XawPrintDialogClosePrinterConnection" is defined in printdialog.h,
which is only included when USE_XPRINT is enabled. The xmore component
is built explicitly with --disable-xprint.
I see no indication that it is built with the --disable-xprint.
>How-To-Repeat:
cd /usr/ports/x11/xmore && make install clean
I'm not sure why others have not seen this unless the "XPRINT" variable
has been set in their environment. I'm using a low overhead window manager
(fluxbox) but I've not ran into this before.
>Fix:
I made a (clumsy) patch to get it to build locally but there's probably
a better way to do it in the Makefile.
Patch attached with submission follows:
--- xmore.c.orig 2009-01-25 09:44:52.000000000 -0500
+++ xmore.c 2009-01-25 09:45:39.000000000 -0500
@@ -147,14 +147,14 @@
XtCallActionProc(w, "quit", NULL, NULL, 0);
}
+#ifdef USE_XPRINT
+
static void
printshellDestroyXtProc(Widget w, XtPointer client_data, XtPointer callData)
{
XawPrintDialogClosePrinterConnection(printdialog, False);
}
-#ifdef USE_XPRINT
-
static void
printOKXtProc(Widget w, XtPointer client_data, XtPointer callData)
{
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901252019.n0PKJ0L9064994>