From owner-svn-src-head@freebsd.org Tue Aug 11 12:46:29 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 393F83AD98B; Tue, 11 Aug 2020 12:46:29 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BQsyq5v50z4Tdb; Tue, 11 Aug 2020 12:46:27 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1597149984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ArO/rth6KYhAZxPRiMoV5o6X4/zRtkg5B/Y+BND4k0=; b=fTHH7eL3SJ0AmIW5CvpNds1aQrrvVAutZq7ubCRDbaqIyD0onXU05tEC2tc4Zn0xZ3z7mE IiG/L/V6YC/OT5PMxRvvcL3zhZv8YRhTUQWD8UZKmmm2fn30yNT0nEhyB0EdeiAhuSUOjC afUkI0055ylZY22XfTh7lMYYNclUbyA= Received: from skull.home.blih.net (lfbn-idf2-1-1138-237.w90-92.abo.wanadoo.fr [90.92.20.237]) by mx.blih.net (OpenSMTPD) with ESMTPSA id b7ce17eb (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 11 Aug 2020 12:46:19 +0000 (UTC) Date: Tue, 11 Aug 2020 14:46:18 +0200 From: Emmanuel Vadot To: Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364110 - head/sys/compat/linuxkpi/common/include/linux Message-Id: <20200811144618.38021590f1a2b5eb3fa963c9@bidouilliste.com> In-Reply-To: <202008111241.07BCfeC9064365@repo.freebsd.org> References: <202008111241.07BCfeC9064365@repo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BQsyq5v50z4Tdb X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=fTHH7eL3; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-2.89 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.001]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.01)[-1.014]; DKIM_TRACE(0.00)[bidouilliste.com:+]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; NEURAL_HAM_SHORT(-0.38)[-0.378]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Aug 2020 12:46:29 -0000 On Tue, 11 Aug 2020 12:41:40 +0000 (UTC) Hans Petter Selasky wrote: > Author: hselasky > Date: Tue Aug 11 12:41:40 2020 > New Revision: 364110 > URL: https://svnweb.freebsd.org/changeset/base/364110 > > Log: > Use atomic_clear_rel_long() to implement clear_bit_unlock() in the LinuxKPI > after r363842. > > Suggested by: alc@ > MFC after: 1 week > Sponsored by: Mellanox Technologies > > Modified: > head/sys/compat/linuxkpi/common/include/linux/bitops.h Thanks Hans, I was doing a last build but you beat me to it. And thanks to Alan for suggesting using atomic_clear_rel_long directly. Note that clear_bit_unlock isn't used by any code at the moment so it wasn't a big deal. > Modified: head/sys/compat/linuxkpi/common/include/linux/bitops.h > ============================================================================== > --- head/sys/compat/linuxkpi/common/include/linux/bitops.h Tue Aug 11 12:17:46 2020 (r364109) > +++ head/sys/compat/linuxkpi/common/include/linux/bitops.h Tue Aug 11 12:41:40 2020 (r364110) > @@ -272,15 +272,11 @@ find_next_zero_bit(const unsigned long *addr, unsigned > #define clear_bit(i, a) \ > atomic_clear_long(&((volatile unsigned long *)(a))[BIT_WORD(i)], BIT_MASK(i)) > > +#define clear_bit_unlock(i, a) \ > + atomic_clear_rel_long(&((volatile unsigned long *)(a))[BIT_WORD(i)], BIT_MASK(i)) > + > #define test_bit(i, a) \ > !!(READ_ONCE(((volatile const unsigned long *)(a))[BIT_WORD(i)]) & BIT_MASK(i)) > - > -static inline void > -clear_bit_unlock(long bit, volatile unsigned long *var) > -{ > - clear_bit(bit, var); > - wmb(); > -} > > static inline int > test_and_clear_bit(long bit, volatile unsigned long *var) -- Emmanuel Vadot