From owner-svn-ports-head@FreeBSD.ORG  Wed Nov  6 07:43:06 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id B22844A6;
 Wed,  6 Nov 2013 07:43:06 +0000 (UTC)
 (envelope-from antoine.brodin.freebsd@gmail.com)
Received: from mail-wi0-x229.google.com (mail-wi0-x229.google.com
 [IPv6:2a00:1450:400c:c05::229])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id D59BC2882;
 Wed,  6 Nov 2013 07:43:05 +0000 (UTC)
Received: by mail-wi0-f169.google.com with SMTP id cb5so4431978wib.2
 for <multiple recipients>; Tue, 05 Nov 2013 23:43:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=aYsKBFP9cOkDHpYJWpnchFEZHH9xK6RmJ7O0DmcYT64=;
 b=UV3FIgCuV4HGE4fw54XOH8VJHpvDumeLbpbJgP7YfLeH3nr+U6MRJpq2/TDE23WMEV
 mjIDKJgF6AnFmC8FUlTFxaexaqx1W5iBjh3ANBmt4wmRDqP36xT8eLtcI0PetPV53zrB
 CGWvWeKuyznBQXNBixuX7zh9AqxoceEHRJlMuEUzcvjoGS2DalPMInajMGEzsNXKRue3
 Nry+BjlchJfiJ1VpXpNQOZvqdL7ZYW185Gif8XJ5ClGGYvLFv+6iT9uiURyh20e0QYyn
 v+jMJiDt/Ixbpej73QU+cdK4TAZuIb5wspP0+NCJrjDwG7fbpuxv0QGJsCoh2KRUNLIS
 A+Tg==
MIME-Version: 1.0
X-Received: by 10.180.221.38 with SMTP id qb6mr1331584wic.8.1383723784236;
 Tue, 05 Nov 2013 23:43:04 -0800 (PST)
Sender: antoine.brodin.freebsd@gmail.com
Received: by 10.194.64.199 with HTTP; Tue, 5 Nov 2013 23:43:04 -0800 (PST)
In-Reply-To: <20131106064318.GC60770@FreeBSD.org>
References: <201311032002.rA3K2hw9017440@svn.freebsd.org>
 <20131106064318.GC60770@FreeBSD.org>
Date: Wed, 6 Nov 2013 08:43:04 +0100
X-Google-Sender-Auth: 0vfnoogDOOYbYXKg829PDgbFBjA
Message-ID: <CAALwa8k=tJF1SZdHfPFqvx8v3gj3VPMfBOttbxYEySNZbv=Ajg@mail.gmail.com>
Subject: Re: svn commit: r332645 - head/graphics/vcg
From: Antoine Brodin <antoine@FreeBSD.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2013 07:43:06 -0000

On Wed, Nov 6, 2013 at 7:43 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Sun, Nov 03, 2013 at 08:02:43PM +0000, Antoine Brodin wrote:
>> New Revision: 332645
>> URL: http://svnweb.freebsd.org/changeset/ports/332645
>>
>> Log:
>>   - Convert to STAGEDIR, the side effect is that the packages are fixed
>>   (this ports uses imake but didn't compress man pages)
>>
>> @@ -33,7 +30,7 @@ pre-patch:
>>               -e "s:%%CFLAGS%%:${CFLAGS}:g" \
>>               -e "s:%%MAKE%%:${MAKE}:g;" \
>>               -e "s:%%LOCALBASE%%:${LOCALBASE}:g" \
>> -             -e "s:%%PREFIX%%:${PREFIX}:g" \
>> +             -e "s:%%PREFIX%%:${STAGEDIR}${PREFIX}:g" \
>
> I assume that you have verified that software does not use this %%PREFIX%%
> value as runtime-valid path (e.g. opens file relative to it).


Yes,  and the qa.sh tests would have spotted this problem too.

Cheers,

Antoine