From nobody Tue Apr 19 07:02:21 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id BA3F811FBB47; Tue, 19 Apr 2022 07:02:40 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from smtp6.goneo.de (smtp6.goneo.de [IPv6:2001:1640:5::8:31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KjF9q37zWz3qth; Tue, 19 Apr 2022 07:02:39 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from hub2.goneo.de (hub2.goneo.de [85.220.129.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by smtp6.goneo.de (Postfix) with ESMTPS id AAA9010A332E; Tue, 19 Apr 2022 09:02:31 +0200 (CEST) Received: from hub2.goneo.de (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPS id BE48010A1E88; Tue, 19 Apr 2022 09:02:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walstatt-de.de; s=DKIM001; t=1650351749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YMRBbnhMLEup7jqmxZDz+51pt5KnAhnKDFtR4MYbzr8=; b=lu3E5wvJsGuMRpEtq2kPSurAJuAnirYfUK1ba4OJQIJHfGB8mTdZWJG/OH+Aelf3P3gqn3 bG5/PHn7VJyAnJnaL7+yiqKxTfqxFZTFN9F1CbmUQJCD4b/EcZJy90jI2XfnGfTYaW9H1W AsC9iB4G3zzlaxyvTogInVDczCe7lLUajHr0yPBf7nN7hSqVy9K7WpnYHfNU2rxjRuiVyS VJ4quL3Z2gAFmthTkIUPVSeaBfZXiFSy8Qc4slLF3bA1SXJY9WJ5xPPHIEgGKqlHVcIdbL waW/qs8Ut1GWLVrCfS9HCNZ0URoc6g+GnkMleaLntt2ENmqG67ZKiSPIuBRZ3w== Received: from freyja (p4fc0ad29.dip0.t-ipconnect.de [79.192.173.41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPSA id 656C010A1E85; Tue, 19 Apr 2022 09:02:29 +0200 (CEST) Date: Tue, 19 Apr 2022 09:02:21 +0200 From: FreeBSD User To: John Baldwin Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 8b83d7e0ee54 - main - Make -Wunused-but-set-variable a fatal error for clang 13+ for kernel builds. Message-ID: <20220419090201.6aa24c73@freyja> In-Reply-To: <202204182311.23INBqfC025671@gitrepo.freebsd.org> References: <202204182311.23INBqfC025671@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-UID: 895c95 X-Rspamd-UID: 20ea34 X-Rspamd-Queue-Id: 4KjF9q37zWz3qth X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=walstatt-de.de header.s=DKIM001 header.b=lu3E5wvJ; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd@walstatt-de.de has no SPF policy when checking 2001:1640:5::8:31) smtp.mailfrom=freebsd@walstatt-de.de X-Spamd-Result: default: False [-2.80 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[walstatt-de.de:s=DKIM001]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[walstatt-de.de]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[walstatt-de.de:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; ASN(0.00)[asn:25394, ipnet:2001:1640::/32, country:DE]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[79.192.173.41:received] X-ThisMailContainsUnwantedMimeParts: N On Mon, 18 Apr 2022 23:11:52 GMT John Baldwin wrote: > The branch main has been updated by jhb: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=8b83d7e0ee54416b0ee58bd85f9c0ae7fb3357a1 > > commit 8b83d7e0ee54416b0ee58bd85f9c0ae7fb3357a1 > Author: John Baldwin > AuthorDate: 2022-04-18 23:06:27 +0000 > Commit: John Baldwin > CommitDate: 2022-04-18 23:06:27 +0000 > > Make -Wunused-but-set-variable a fatal error for clang 13+ for kernel > builds. > Reviewed by: imp, emaste > Differential Revision: https://reviews.freebsd.org/D34949 > --- > sys/conf/kern.mk | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/sys/conf/kern.mk b/sys/conf/kern.mk > index f97be774ea10..b86149ab4618 100644 > --- a/sys/conf/kern.mk > +++ b/sys/conf/kern.mk > @@ -42,9 +42,6 @@ CWARNEXTRA?= -Wno-error=tautological-compare > -Wno-error=empty-body \ -Wno-error=pointer-sign > CWARNEXTRA+= -Wno-error=shift-negative-value > CWARNEXTRA+= -Wno-address-of-packed-member > -.if ${COMPILER_VERSION} >= 130000 > -CWARNFLAGS+= -Wno-error=unused-but-set-variable > -.endif > .endif # clang > > .if ${COMPILER_TYPE} == "gcc" > Hello, this setting results in a kernel build failure: [...] /usr/src/sys/dev/uart/uart_core.c:348:6: error: variable 'rxp' set but not used [-Werror,-Wunused-but-set-variable] int rxp; [...] and, when having set makeoptions WITH_EXTRA_TCP_STACKS=YES in the kernel definition/configuration: [...] --- rack_bbr_common.o --- /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/rack_bbr_common.c:399:16: error: variable 'inp' set but not used [-Werror,-Wunused-but-set-variable] struct inpcb *inp; [...] Kind regards, Oliver