From owner-freebsd-arch Sat Jan 20 14:27:12 2001 Delivered-To: freebsd-arch@freebsd.org Received: from pcnet1.pcnet.com (pcnet1.pcnet.com [204.213.232.3]) by hub.freebsd.org (Postfix) with ESMTP id EA58D37B400 for ; Sat, 20 Jan 2001 14:26:54 -0800 (PST) Received: (from eischen@localhost) by pcnet1.pcnet.com (8.8.7/PCNet) id RAA09540; Sat, 20 Jan 2001 17:26:27 -0500 (EST) Date: Sat, 20 Jan 2001 17:26:26 -0500 (EST) From: Daniel Eischen To: "Jacques A. Vidrine" Cc: arch@freebsd.org Subject: Re: Request For Review: libc/libc_r changes to allow -lc_r In-Reply-To: <20010120153158.A88123@hamlet.nectar.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 20 Jan 2001, Jacques A. Vidrine wrote: > On Fri, Jan 19, 2001 at 07:38:00PM -0500, Daniel Eischen wrote: > [snip] > > Overview of the changes > > ----------------------- > > Thanks for the hard work and the great overview! > > I have one objection: > > [snip] > > _thread_sys_foo - actual syscall > > _foo - weak definition to _thread_sys_foo > > foo - weak definition to _thread_sys_foo > > > > I've changed all the instances of foo() to _foo() in libc for > > those hidden system calls. Anyone modifying or adding to libc > > will have to be careful to use the same conventions. > > Please, no. Kill `un-namespace' and let us continue to use the > correct name for `foo'. Adding underscores in front of lotsa common > calls hurt my eyes and hinders porting between different libc > implementations (e.g. our `old' one, other *BSDs). Sorry, I don't think that's going to work, especially for sigaction, flock, and kevent. These cannot be #define'd to there underscore(_) equivalents because it would also redefine struct sigaction, struct flock, and struct kevent. The tree has already been populated with lotsa _foo calls; this just finishes the job. > By the way, should it be __thread_sys_foo and __foo? Two underscores? > ISTR some rule about using a single leading underscore for file scope > (e.g. macros) and two for global scope. I don't recall that, but anything for file scope that isn't a macro can be static and not use the underscores. Macros are usually upper case anyways. > Finally, I hope this will lead us into introducing all non- Standard C > (or at least non-POSIX) function identifiers in the same fashion, so > as to clean up our namespace. For example, err(3). I think that's a good idea, and am willing to do the work if given list of the functions that need to be changed. -- Dan Eischen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message