From owner-freebsd-python@FreeBSD.ORG Wed Sep 7 09:10:34 2011 Return-Path: Delivered-To: freebsd-python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B9FC5106564A; Wed, 7 Sep 2011 09:10:34 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-gx0-f178.google.com (mail-gx0-f178.google.com [209.85.161.178]) by mx1.freebsd.org (Postfix) with ESMTP id 63E3F8FC15; Wed, 7 Sep 2011 09:10:34 +0000 (UTC) Received: by gxk8 with SMTP id 8so5361085gxk.37 for ; Wed, 07 Sep 2011 02:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=dGCZOFMgdYxiVLuflBbmhDHvDRbfz3M0xkfFVB+MZ9o=; b=JNSbxUcrsLmqvRVSt/oI+5xF/oE8OVBqSErPzHhKzSQmF/zlXd94SO8Oebp9qFAPq/ IB0fYZU7IFspvVTBhnal8lb7Ji8lhXIFr0AumBM1D3zlsIdeJ0CGhTW6vWBelet5UBBK 0kcrx8yJHZLzDf8yHLy2VjDqIIEaE7Aqe03bA= MIME-Version: 1.0 Received: by 10.150.8.10 with SMTP id 10mr4620544ybh.60.1315386633677; Wed, 07 Sep 2011 02:10:33 -0700 (PDT) Sender: lwhsu.freebsd@gmail.com Received: by 10.150.229.16 with HTTP; Wed, 7 Sep 2011 02:10:33 -0700 (PDT) In-Reply-To: <20110907110255.GA1795@freebsd.ifr.lan> References: <20110906205704.GA38513@freebsd.ifr.lan> <20110907110255.GA1795@freebsd.ifr.lan> Date: Wed, 7 Sep 2011 17:10:33 +0800 X-Google-Sender-Auth: SjZK03b0rmG2T0uGZG75xhtt9EA Message-ID: From: Li-Wen Hsu To: Sofian Brabez Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Python Team Subject: Re: Update of devel/py-twisted to 11.0.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2011 09:10:34 -0000 Looks good, please go ahead commit and close the related PRs. Thanks for your help! On Wed, Sep 7, 2011 at 19:02, Sofian Brabez wrote: > Hi python@, > > On Wed, Sep 07, 2011 at 02:02:43PM +0800, Li-Wen Hsu wrote: >> Hello Sofian, >> >> Thanks for working on this, python@ definitely need more power! >> >> Please see the reply inline. >> >> On Wed, Sep 7, 2011 at 04:57, Sofian Brabez wrote: >> > Hi python@, >> > >> > This afternoon, I've merged my initial update to the twisted related p= orts with >> > the patch of lwhsu@ [1]. My patch is there [2]. >> > >> > My patch make happy portlint, add LICENSE in each twisted ports and ad= d new >> > OPTIONS for twistedPair port. >> >> And please also add pair_DEPENDS in bsd.python.mk, that is around line 6= 41. > > Done >> >> > Please lwhsu@ notice than all twisted ports are sharing the >> > ${PYTHON_SITELIBDIR}/twisted/plugins folder that's why I've replaced t= he @dirrm >> > by a @dirrmtry in pkg-plist. >> >> Thanks for reminding me this, I think we have >> >> =C2=A0 =C2=A0 @dirrm %%PYTHON_SITELIBDIR%%/twisted/plugins in >> >> in devel/py-twistedCore/pkg-plist, and all other twisted ports depends >> on twistedCore, so we probably don't need to have @dirrm nor @dirrmtry >> in other ports. >> They sneaked in my patch because I forget this, so just removing them >> is fine. (I was planning getting maintainer's approval on general idea >> then doing a more substantial patch.) >> Using @dirrmtry is fine, too. >> > > Imho, we should keep the @dirrmtry directive to remember us that all twis= ted > ports install files in ${PYTHON_SITELIBDIR}/twisted/plugins and agreed th= e only > @dirrm should be in devel/py-twistedCore/pkg-plist file. >> > I would like to have your approbation to commit it, and sent it to my = mentors >> > for their approbations, I start working on this one because I took the= pr >> > ports/155570 but lwhsu@ inform me about ports/159954 on #freebsd-pytho= n. >> > >> > Below the tinderbox build logs: >> > >> > http://regis.goodking.org/tb/index.php?action=3Dlist_buildports&build= =3D7-sbz&search_port_name=3Dtwisted&Go=3DGo >> > http://regis.goodking.org/tb/index.php?action=3Dlist_buildports&build= =3D8-sbz&search_port_name=3Dtwisted&Go=3DGo >> > http://regis.goodking.org/tb/index.php?action=3Dlist_buildports&build= =3D9-sbz&search_port_name=3Dtwisted&Go=3DGo >> >> All looks good, and I also tested building all other ports depends on >> twisted, all are fine. =C2=A0Is anybody aware non-backward-compatible >> change? >> >> Another thing, I found there is no twisted 11.0.0 distfiles in >> http://tmrc.mit.edu/mirror/twisted/, that's why I removed them from >> MASTER_SITES, could you check it again? > > Indeed, I remove them, we will see in the future if they remirrored them. >> >> Please consider my suggestions, thanks! >> > > Patch update with your suggestions, now I'm waiting your go ;), I save th= e old > version [1] and the new [2] there. >> > Regards >> > >> > [1] http://people.freebsd.org/~lwhsu/twisted-11.0.0.diff >> > [2] http://people.freebsd.org/~sbz/twisted-11.0.0.diff >> > >> > -- >> > Sofian Brabez >> > >> >> >> >> -- >> Li-Wen Hsu >> http://lwhsu.org > > Regards > > [1] http://people.freebsd.org/~sbz/twisted-11.0.0.old.diff > [2] http://people.freebsd.org/~sbz/twisted-11.0.0.diff > > -- > Sofian Brabez > --=20 Li-Wen Hsu http://lwhsu.org