Date: Wed, 6 Nov 2013 07:44:25 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Veniamin Gvozdikov <vg@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r332677 - in head/sysutils: . dunst Message-ID: <20131106074425.GH60770@FreeBSD.org> In-Reply-To: <201311040941.rA49fEMj003374@svn.freebsd.org> References: <201311040941.rA49fEMj003374@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 04, 2013 at 09:41:14AM +0000, Veniamin Gvozdikov wrote: > New Revision: 332677 > URL: http://svnweb.freebsd.org/changeset/ports/332677 > > +CATEGORIES= sysutils > +MASTER_SITES= http://www.knopwob.org/public/dunst-release/ > + > +MAINTAINER= rodperson@rodperson.com > +COMMENT= Lightweight notification deamon s/deamon/daemon/ perhaps? You could've added LICENSE=BSD, by the way. > +LIB_DEPENDS= cairo:${PORTSDIR}/graphics/cairo \ > + dbus:${PORTSDIR}/devel/dbus \ > + execinfo:${PORTSDIR}/devel/libexecinfo \ > + freetype:${PORTSDIR}/print/freetype2 \ > + notify:${PORTSDIR}/devel/libnotify \ > + pango:${PORTSDIR}/x11-toolkits/pango \ > + xdg-basedir:${PORTSDIR}/x11/libxdg-basedir You could've also used modern syntax for LIB_DEPENDS. > +MAKE_ARGS+= MANPREFIX="${PREFIX}/man" > + > +ALL_TARGET= dunst dunstify dunst.1 > +INSTALL_TARGET= install > + > +LDFLAGS+= -O3 -g -Wall -rdynamic -lexecinfo -O3 -g? Really? We usually try hard to get rid of this upstream shit, not to add it. In rare cases when something obnoxious like this is actually *required* for software's proper operation, it should be accompanied by the explanatory comment. > +CFLAGS+= -I${LOCALBASE}/include Polluting CFLAGS with preprocessor option should only be done if software does not support CPPFLAGS, I hope it was verified that it indeed does not. > @@ -0,0 +1,6 @@ > +Dunst is a lightweight replacement for the notification-daemons provided > +by most desktop environments. It's very customizable, doesn't depend on > +any toolkits and therefore fits in those windowmanager centric setups we > +all love to customize to perfection. > + > +WWW: http://www.knopwob.org/dunst Nicely written description. Using double space after the full stop would make it even better at the right side. ;-) I would rather not discuss the necessity of comma before "and" and if "window manager" ought to be spelled separately, but would mention that terminating WWW line (per PH, section 3.2.1) would be nice. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131106074425.GH60770>