From owner-freebsd-current@FreeBSD.ORG  Thu Mar 14 08:42:49 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 1E7C1EAB;
 Thu, 14 Mar 2013 08:42:49 +0000 (UTC)
 (envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72])
 by mx1.freebsd.org (Postfix) with ESMTP id CE7ACBDE;
 Thu, 14 Mar 2013 08:42:48 +0000 (UTC)
Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149])
 by mail.dawidek.net (Postfix) with ESMTPSA id BD13B7AF;
 Thu, 14 Mar 2013 09:39:33 +0100 (CET)
Date: Thu, 14 Mar 2013 09:44:20 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Dirk Engling <erdgeist@erdgeist.org>
Subject: Re: pidfile_open incorrectly returns EAGAIN when pidfile is locked
Message-ID: <20130314084420.GH1372@garage.freebsd.pl>
References: <513F8D20.2050707@erdgeist.org>
 <201303131118.36811.jhb@freebsd.org>
 <20130313212750.GC1372@garage.freebsd.pl>
 <alpine.BSF.2.00.1303132256540.67262@erdgeist.org>
 <20130313220831.GF1372@garage.freebsd.pl>
 <51417C19.9060002@erdgeist.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="7J16OGEJ/mt06A90"
Content-Disposition: inline
In-Reply-To: <51417C19.9060002@erdgeist.org>
X-OS: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-current@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Mar 2013 08:42:49 -0000


--7J16OGEJ/mt06A90
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 14, 2013 at 08:28:25AM +0100, Dirk Engling wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>=20
> On 13.03.13 23:08, Pawel Jakub Dawidek wrote:
>=20
> > I think I considered something similar at first, but the change I=20
> > proposed was optimal, IMHO at the cost of producing pretty large
> > diff, because of indentation change. But to be sure, can you send a
> > patch of your proposed change?
>=20
> http://erdgeist.org/arts/software/Code/pidfile.c.diff

Right. Your patch assumes EWOULDBLOCK is equal to EAGAIN, which is true
on FreeBSD, but is not portable. Also in case pidptr is NULL you compare
errno three times instead of just one (not a big deal of course, just
something that could be done a bit more optimal:)).

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--7J16OGEJ/mt06A90
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlFBjeQACgkQForvXbEpPzTiUgCffVExSr5zUMsgST7+nXsv6Qzv
6agAmgNFGJPKCnZxbwEEdi3S8z3SUhho
=5Sc5
-----END PGP SIGNATURE-----

--7J16OGEJ/mt06A90--