From owner-p4-projects@FreeBSD.ORG  Mon Mar 20 20:41:57 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 801BA16A426; Mon, 20 Mar 2006 20:41:57 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4D5EF16A422;
	Mon, 20 Mar 2006 20:41:57 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BBC2943D53;
	Mon, 20 Mar 2006 20:41:56 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from localhost (john@localhost [127.0.0.1])
	by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k2KKfphA003109;
	Mon, 20 Mar 2006 15:41:54 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: "Christian S.J. Peron" <csjp@freebsd.org>
Date: Mon, 20 Mar 2006 15:30:37 -0500
User-Agent: KMail/1.9.1
References: <200603201752.k2KHqO5h027598@repoman.freebsd.org>
	<441F0B39.3000406@FreeBSD.org>
In-Reply-To: <441F0B39.3000406@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200603201530.41496.jhb@freebsd.org>
X-Virus-Scanned: ClamAV 0.87.1/1345/Mon Mar 20 07:03:16 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-3.6 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx
Cc: Todd Miller <millert@freebsd.org>,
	Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 93645 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Mar 2006 20:41:57 -0000

On Monday 20 March 2006 15:06, Christian S.J. Peron wrote:
> Todd Miller wrote:
> 
> >http://perforce.freebsd.org/chv.cgi?CH=93645
> >
> >Change 93645 by millert@millert_p3 on 2006/03/20 17:51:24
> >
> >	Arg pointer in mac_thread_syscall_{enter,exit} should be
> >	register_t * not int *.  Fixes compilation problem on amd64.
> >
> >Affected files ...
> >
> >.. //depot/projects/trustedbsd/sebsd/sys/security/mac/mac_system.c#10 edit
> >
> >Differences ...
> >
> >==== //depot/projects/trustedbsd/sebsd/sys/security/mac/mac_system.c#10 (text+ko) ====
> >
> >@@ -282,7 +282,7 @@
> > }
> > 
> > int
> >-mac_thread_syscall_enter(struct thread *td, int *args, int code)
> >+mac_thread_syscall_enter(struct thread *td, register_t *args, int code)
> > {
> > 	int error;
> > 
> >@@ -293,7 +293,7 @@
> > }
> > 
> > void
> >-mac_thread_syscall_exit(struct thread *td, int *args, int code, int errcode)
> >+mac_thread_syscall_exit(struct thread *td, register_t *args, int code, int errcode)
> > {
> > 
> > 	if (!mac_enforce_syscall)
> >
> >
> >  
> >
> Does this still build on i386?

Probably, register_t == int on i386.  This is the right change though,
syscall arguments are typically passed in registers and/or on the stack,
and stack values should fit in registers.

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org