From owner-freebsd-bugs@freebsd.org  Wed Dec  6 12:57:26 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC3D6E9FD43
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Wed,  6 Dec 2017 12:57:26 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DA19A713FF
 for <freebsd-bugs@FreeBSD.org>; Wed,  6 Dec 2017 12:57:26 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vB6CvQX4064643
 for <freebsd-bugs@FreeBSD.org>; Wed, 6 Dec 2017 12:57:26 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 224143] [PATCH] fmtcheck(3) misjudges format string with fewer
 arguments
Date: Wed, 06 Dec 2017 12:57:26 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: rokuyama@rk.phys.keio.ac.jp
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status keywords bug_severity priority component assigned_to
 reporter attachments.created
Message-ID: <bug-224143-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2017 12:57:27 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224143

            Bug ID: 224143
           Summary: [PATCH] fmtcheck(3) misjudges format string with fewer
                    arguments
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: rokuyama@rk.phys.keio.ac.jp
          Keywords: patch

Created attachment 188583
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D188583&action=
=3Dedit
Correct oversight of wrong format string with fewer arguments.

fmtcheck(3) misjudges some format strings as valid when they have fewer
arguments
than default format strings have:

----
% uname -a
FreeBSD freebsd 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r325595: Thu Nov  9
16:03:47 UTC 2017=20=20=20=20
root@releng3.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64
% cat test.c
#include <stdio.h>
int main() {
        const char *s1 =3D "One argument: %d", *s2 =3D "Two arguments: %d %=
d";
        printf("%s\n", fmtcheck(s1, s2));
        printf("%s\n", fmtcheck(s2, s1));
}
% cc test.c && ./a.out
One argument: %d
One argument: %d
----

Here, the first line should be "Two arguments: %d %d".

Please apply the attached patch, which has been committed to NetBSD by myse=
lf:
http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libc/gen/fmtcheck.c#rev1.11

--=20
You are receiving this mail because:
You are the assignee for the bug.=