From owner-freebsd-gecko@freebsd.org  Sun Mar 17 16:26:00 2019
Return-Path: <owner-freebsd-gecko@freebsd.org>
Delivered-To: freebsd-gecko@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBB6A15413FE
 for <freebsd-gecko@mailman.ysv.freebsd.org>;
 Sun, 17 Mar 2019 16:26:00 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id 5487886658
 for <freebsd-gecko@freebsd.org>; Sun, 17 Mar 2019 16:26:00 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 0DBF915413FD; Sun, 17 Mar 2019 16:26:00 +0000 (UTC)
Delivered-To: gecko@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EDDD615413FC
 for <gecko@mailman.ysv.freebsd.org>; Sun, 17 Mar 2019 16:25:59 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 8AAA686657;
 Sun, 17 Mar 2019 16:25:59 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 749307B52; Sun, 17 Mar 2019 16:25:59 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Graham Perrin <grahamperrin@gmail.com>
Cc: gecko@freebsd.org
Subject: Re: Building (deleted) Waterfox 56.2.8: error: missing documentation
 for macro
References: <496db844-cb0b-1b53-b498-beec9324b9c0@gmail.com>
Date: Sun, 17 Mar 2019 17:25:54 +0100
In-Reply-To: <496db844-cb0b-1b53-b498-beec9324b9c0@gmail.com> (Graham Perrin's
 message of "Sun, 17 Mar 2019 15:00:46 +0000")
Message-ID: <mult-tqlp-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Queue-Id: 8AAA686657
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-2.93 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.99)[-0.993,0];
 NEURAL_HAM_LONG(-1.00)[-0.999,0];
 NEURAL_HAM_SHORT(-0.94)[-0.937,0];
 ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]
X-BeenThere: freebsd-gecko@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gecko Rendering Engine issues <freebsd-gecko.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-gecko>,
 <mailto:freebsd-gecko-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gecko/>
List-Post: <mailto:freebsd-gecko@freebsd.org>
List-Help: <mailto:freebsd-gecko-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-gecko>,
 <mailto:freebsd-gecko-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Mar 2019 16:26:01 -0000

Graham Perrin <grahamperrin@gmail.com> writes:

> error: missing documentation for macro
>    --> 
> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/values.rs:341:1
>     |
> 341 | macro_rules! define_css_keyword_enum {
>     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>     |
> note: lint level defined here
>    --> 
> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/lib.rs:12:22
>     |
> 12  | #![deny(unsafe_code, missing_docs)]
>     |                      ^^^^^^^^^^^^

Looks like a regression from Rust 1.33 update.

Either remove missing_docs from #![deny(...)] lines (or lines themselves)
for each one that triggers error (no need to bother with unused ones) or
add MOZ_OPTIONS+=--disable-stylo to Makefile.local.

www/firefox-esr et al. simply backported upstream fixes for warnings to
avoid having to maintain workarounds forever. Rebasing those against
very old Stylo code isn't worth the effort.