From owner-svn-src-all@freebsd.org Sat Apr 20 16:43:25 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E823156CCFF; Sat, 20 Apr 2019 16:43:25 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0887169EC9; Sat, 20 Apr 2019 16:43:25 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x536.google.com with SMTP id v12so3982885pgq.1; Sat, 20 Apr 2019 09:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Zeo3fBGcDlFI3oUoyUCfOyJD/qv5pHHbGK7uUVJlKiQ=; b=r5MaNvS9RPW2f/0DTnr+izQRESOnodE2nD80i7YWX5vNma/GvalO/gfSWgSKWb4lTS wwwI6Q7dKPBhpT2EZUVYzbls2VQXlzpv7XnqaoOz1d0TALbojP+L/mRkpk/W/HG/Qpnn 5m/B/1FRNwe5VBi/QLgie9J2XOH1sk4mc10JzydyJ1Ezqp+3jhYNCLMbN3UyZC8g8xA7 KThi3xBoNeC/YPS+PSvJdyw7GXeixY0jy50MEQdLYd98EsgwWwKHfIPbXowdQtJJaR0S hcC2F1QmtJ3DUTn76md9qru8ZVi3b92qjTiwFPNfN9Nh3eoe7cWIVKMGo31iyotWHIsy x1wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Zeo3fBGcDlFI3oUoyUCfOyJD/qv5pHHbGK7uUVJlKiQ=; b=pZFfEibt9N28Ubgrx9ibm4cDQVM62OhA8NqSUtp9JuzYFIbNUGUYbURt1PQlNnQpW3 YHLEnkRAGsDHawxp4/NlIZAKdsBWt/L9XWzUnR2yEkxemU5ZsvImRu8NyFDBSA2gLT4O bAR6xgRJydXISqvNcRa20MyQNgi7w6ocX/X+s3Pb6kqDNsCCpy62UC/BTUd/IDyFvwqx HHEMtcsTjpX34PTVvAuzvl40wI6zcJ+gGrPAjkGFKa0JYNCocdcspaYEUkooH9slC/MW JYO+YrFx4GuofbdqtNRtbmgwTTKF9ZZT4u37Xj9gmXngDSbFR1tp+bJcjSTU6+sKgtck dJ1w== X-Gm-Message-State: APjAAAX6wRMYlLvQjGgJWDZ56Pqwvzr/INDhxX8OUJnraf+3e3IuTin0 BI/CQuYXTbPOjL93xWN5JizxwcIrivs= X-Google-Smtp-Source: APXvYqzLlzG6dz3jNIoxYvhpX+lbv2DqSPt5KrBQ7MxMIK1WVlaDGHYZ6mc1bFKd0eqcz3AH0nxCRQ== X-Received: by 2002:a63:28c:: with SMTP id 134mr10047079pgc.278.1555778603666; Sat, 20 Apr 2019 09:43:23 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id n20sm22534208pgd.92.2019.04.20.09.43.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Apr 2019 09:43:22 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r346443 - head/tests/sys/opencrypto From: Enji Cooper In-Reply-To: <3dc61795-3802-513e-93ff-3d6493eabe36@FreeBSD.org> Date: Sat, 20 Apr 2019 09:43:22 -0700 Cc: Enji Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201904201543.x3KFhSAl037969@repo.freebsd.org> <3dc61795-3802-513e-93ff-3d6493eabe36@FreeBSD.org> To: John Baldwin X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: 0887169EC9 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.954,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Apr 2019 16:43:25 -0000 > On Apr 20, 2019, at 9:38 AM, John Baldwin wrote: >=20 > On 4/20/19 9:32 AM, Enji Cooper wrote: >>=20 >>> On Apr 20, 2019, at 9:31 AM, Enji Cooper = wrote: >>>=20 >>>=20 >>>> On Apr 20, 2019, at 9:30 AM, John Baldwin > wrote: >>>>=20 >>>> On 4/20/19 8:43 AM, Enji Cooper wrote: >>>>> Author: ngie >>>>> Date: Sat Apr 20 15:43:28 2019 >>>>> New Revision: 346443 >>>>> URL: https://svnweb.freebsd.org/changeset/base/346443 = >>>>>=20 >>>>> Log: >>>>> tests/sys/opencrypto: fix whitespace per PEP8 >>>>>=20 >>>>> Replace hard tabs with four-character indentations, per PEP8. >>>>>=20 >>>>> This is being done to separate stylistic changes from the tests = from functional >>>>> ones, as I accidentally introduced a bug to the tests when I used = four-space >>>>> indentation locally. >>>>>=20 >>>>> No functional change. >>>>=20 >>>> Wow, this is really painful for the 4-5 open reviews I have = outstanding as it >>>> makes a merge disaster. >>>=20 >>> Sorry ;_;=E2=80=A6 >>=20 >> Being more constructive: I will back out the change, then = reapply it later. >> Thank you, >=20 > Ok, is it easy to reapply using a script or some such? Also, in = general I do prefer > this indentation as 1) it works out of the box in emacs, and 2) many = of the lines in > cryptotest.py especially are indented pretty far over making it hard = to read. Yeah. I basically did `%s/ /. /g` in vim :). Backed out = via r346452. Using hard tabs in python should really be verboten, except when = dealing with docstrings, etc. It=E2=80=99s so easy to screw up = programs/introduce dead code by not indenting things consistently with = four-space indents. Thanks! -Enji=