From owner-freebsd-net@FreeBSD.ORG  Fri Dec 12 12:59:49 2008
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2F3391065696;
	Fri, 12 Dec 2008 12:59:49 +0000 (UTC)
	(envelope-from rrs@lakerest.net)
Received: from lakerest.net (unknown [IPv6:2001:240:585:2:203:6dff:fe1a:4ddc])
	by mx1.freebsd.org (Postfix) with ESMTP id 636FA8FC1B;
	Fri, 12 Dec 2008 12:59:48 +0000 (UTC)
	(envelope-from rrs@lakerest.net)
Received: from [10.1.1.54] ([10.1.1.54]) (authenticated bits=0)
	by lakerest.net (8.14.1/8.14.1) with ESMTP id mBCCxlHS016193
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT);
	Fri, 12 Dec 2008 07:59:47 -0500 (EST)
	(envelope-from rrs@lakerest.net)
DKIM-Signature: a=rsa-sha1; c=simple/simple; d=lakerest.net; s=mail;
	t=1229086787; h=Cc:Message-Id:From:To:In-Reply-To:Content-Type:
	Content-Transfer-Encoding:Mime-Version:Subject:Date:References:
	X-Mailer; b=ah1cgAowEsdhSuhEWiM4BGx9tsfVqlBEPdCYkTN74rF5NQy4bMexPhu
	8Frd2XiYd7QUkDP9GFC9JrDxUjvmhww==
Message-Id: <57BBB796-7E00-4D96-BACE-1306FC4C1417@lakerest.net>
From: Randall Stewart <rrs@lakerest.net>
To: "Bruce M. Simpson" <bms@FreeBSD.org>
In-Reply-To: <494157DF.6030802@FreeBSD.org>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v929.2)
Date: Fri, 12 Dec 2008 07:59:46 -0500
References: <D72E9703-C8E7-4A21-A71E-A4B4C2D7E8F4@lakerest.net>	<49249443.8050707@elischer.org>	<76CF7D15-251F-4E43-86BE-AD96F48AF123@lakerest.net>	<200811201450.30016.max@love2party.net>
	<24BD4A21-E10D-4E09-8C33-3FCF930A0495@lakerest.net>
	<494157DF.6030802@FreeBSD.org>
X-Mailer: Apple Mail (2.929.2)
Cc: freebsd-net <freebsd-net@FreeBSD.org>
Subject: Re: Heads up ---  Thinking about UDP and tunneling
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Dec 2008 12:59:49 -0000

Bruce:


On Dec 11, 2008, at 1:11 PM, Bruce M. Simpson wrote:

> Hi,
>
> I am missing context of what Max's suggestion was, do you have a  
> reference to an old email thread?

As to the context...
Nov 18 2008 10:01 (am Eastern) I started a thread
"Thinking about UDP and tunneling"


>
>
> Style bugs:
> * needs style(9) and whitespace cleanup.
Hmm.. I thought I had got all this stuff... I actually (shudder)  
switched
to vi  since my emacs spacing always messes up.. in the SCTP code I  
have the
s9indent function that fixes any issues.. but I did not want to run that
on the udp src and cause other changes ...

I will go back and look at the patch..


>
> * C typedefs should be suffixed with _t for consistency with other  
> kernel typedefs.

Good point I will fix  the stuff to have _t in it :-)
>
> * Function typedefs usually named like foo_func_t (see other  
> subsystems)

R

>
>
> Have you looked at m_apply() ? It already exists for stuff like this  
> i.e. functions which act on an mbuf chain, although it doesn't  
> necessarily expect chain heads.
>
> cheers
> BMS
>

------------------------------
Randall Stewart
803-317-4952 (cell)
803-345-0391(direct)