From owner-svn-ports-all@freebsd.org Thu Nov 19 23:30:25 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3435C47730E; Thu, 19 Nov 2020 23:30:25 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CcbWj0fvwz3mj1; Thu, 19 Nov 2020 23:30:25 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1605828625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WbzQoBDsrpSgFMgVT+AseBj+nPSDCnTvBmmG7yuSPFI=; b=iOXNSGS8oF0+sKFBgwO/+lIQc+LzvuvYWSg0uD5FhC5jR24t7SXN26TsRsiq8JcfiRPJP+ p4C4n1K2D6iHelmONND3ZzkIuL8PM1Bqoc5UapsvjGclrhXuiy8c5HzYg3/REl18vDkNYj 7vqkcIsWW9p91Cn2X8S03yy2Wr/CxY2q3UaX/81b9ilkX6osaho9VfdYkIxYJXgL53jKBL 7ph2Cd8HlNz1umFYGL+xqW9NNzspdXxoXnymMVb9AKALLs0Co60yDXox/MB6VoW1y+uar+ j+1AGQXv1IVfRlZmrcOGcFqx+uSALrC9gNDn6sqFZnv9hVMu7aRh6KkY4TXT5A== Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 56464F5A8; Thu, 19 Nov 2020 23:30:24 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 6FCCA1F731; Thu, 19 Nov 2020 23:30:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id M5oWVoAp-RTH; Thu, 19 Nov 2020 23:30:15 +0000 (UTC) To: Jilles Tjoelker , Mathieu Arnold , svn-ports-all@freebsd.org DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com E6D181F726 Cc: ports-committers@freebsd.org, svn-ports-head@freebsd.org, =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= References: <202011111329.0ABDTqUD035770@repo.freebsd.org> <20201119230309.GA10938@stack.nl> From: Bryan Drewery Organization: FreeBSD Subject: Re: svn commit: r554893 - head/Mk/Scripts Message-ID: <3568316e-f84c-984d-7d67-cd09a46c5742@FreeBSD.org> Date: Thu, 19 Nov 2020 15:30:14 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201119230309.GA10938@stack.nl> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RC1lmUz7EBdPmReWQJi2J0fUx1AyVD6Wx" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1605828625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WbzQoBDsrpSgFMgVT+AseBj+nPSDCnTvBmmG7yuSPFI=; b=HXSW0HogG7RKra3KlnOhN/k+ZsTP/qcVDCiYGp9jAaT9PgBR0m88VOBjCqsmulIVRnfcW7 h7wdca6dK8r7RSQ2HiJcAv5sCJbi/MMhpG0fu/TEAmwXj/EpDFkf8yoIb5VYaacPvEw5Du OhsKzo1j76hC38rIjpUk+h7CkO+ivXehYhu69zFZHIE5eGgE1/O8z4hhZPuRC0EM/226Lg vre7IA6HV3Kleqi2ma2X5rnpMr3eDnupyu75g9Wqn5uo8MtsCPglkkxb6FfIT8bfYOz5sa b9/uS0SO1K6Pv4JluBarpIGg8WCLdwyEjW2ESY9RY57Yp7d6HRoaRTxP+Gkh4A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1605828625; a=rsa-sha256; cv=none; b=ukywu1+SOZx9Q9u56biQKZqJqwqcpfqIt0PBl4lWf8w4HiqjO6YMA2XkRBB8lMXO/fO7Fz lZFt1DU0l0s0wrQMGeX0/BXgZdfSMnsQpeva81Fw5bnMK8i1pBY4X8yx2L3MWijlB31CJR UsDKCgky7wftKEHC3rizLQN0y6yTd1h2yCs6818NlmY4JpvThSi2xSyrtjpsG8M8YQ3hcO a0jhRWjwHWTAehBZiJnX8aGcrNXrhlGutaOc5HMcaGCvAti4KKDUXRww4weig8xQkmjIhT h8YFTzz5x3I6KagvAaIJLImMFZaI0eX6dSEhmLN3E4KXwFEInZHBntKJX+dH7Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2020 23:30:25 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RC1lmUz7EBdPmReWQJi2J0fUx1AyVD6Wx Content-Type: multipart/mixed; boundary="dhSY4123DpLhUsaLrSVFYadNEoRbRx72e"; protected-headers="v1" From: Bryan Drewery To: Jilles Tjoelker , Mathieu Arnold , svn-ports-all@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-head@freebsd.org, =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= Message-ID: <3568316e-f84c-984d-7d67-cd09a46c5742@FreeBSD.org> Subject: Re: svn commit: r554893 - head/Mk/Scripts References: <202011111329.0ABDTqUD035770@repo.freebsd.org> <20201119230309.GA10938@stack.nl> In-Reply-To: <20201119230309.GA10938@stack.nl> --dhSY4123DpLhUsaLrSVFYadNEoRbRx72e Content-Type: multipart/mixed; boundary="------------A8C5A05EC0328B6279B2CFCD" Content-Language: en-US This is a multi-part message in MIME format. --------------A8C5A05EC0328B6279B2CFCD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/19/2020 3:03 PM, Jilles Tjoelker wrote: > On Thu, Nov 19, 2020 at 11:41:57AM -0800, Bryan Drewery wrote: >> On 11/11/2020 5:29 AM, Mathieu Arnold wrote: >>> Author: mat >>> Date: Wed Nov 11 13:29:52 2020 >>> New Revision: 554893 >>> URL: https://svnweb.freebsd.org/changeset/ports/554893 >>> Log: >>> Add set pipefail in most framework scripts. >>> set pipefail changes the pipeline return status from being the retu= rn >>> status of the last command to the last non 0 exit status of any com= mand >>> in the pipeline. This is needed to make sure all the commands in a= >>> pipeline did actually return a non 0 status and not only the last o= ne. >> [snip] >>> Modified: head/Mk/Scripts/check-desktop-entries.sh >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/Mk/Scripts/check-desktop-entries.sh Wed Nov 11 13:24:31 2020= (r554892) >>> +++ head/Mk/Scripts/check-desktop-entries.sh Wed Nov 11 13:29:52 2020= (r554893) >>> @@ -4,6 +4,7 @@ >>> # MAINTAINER: portmgr@FreeBSD.org >>> =20 >>> set -e >>> +set -o pipefail >>> =20 >>> . "${dp_SCRIPTSDIR}/functions.sh" >>> =20 >>> >> This can prevent someone from upgrading from an unsupported release. T= he >> workaround is simple enough so I think we should take it rather than >> create burdens for people. >> command set -o pipefail 2>/dev/null || : > Hmm, does an upgrade require building ports on an old release? I meant more about upgrading specific ports while having an unsupported FreeBSD release. As we move towards pkgbase it [ports compat policy] really could block full system upgrades. >=20 > When scripts are written for use with 'set -o pipefail', allowing them > to run without it seems unwise. Very good point. Thank you for the rest of your response too. directed in general: Pipefail came in 12.1 which released just 1 year ago. I choose to use a 12.0 jail to ensure compatibility for users. If we are going to make it harder on users it should be worth it and for something like pipefail there is often an workaround. The reality is not everyone is on a supported FreeBSD version but if they want to upgrade their ports why stop them? I despise us making draconian decisions about what our users are allowed to do. I think it is fair to warn them about unsupported FreeBSD version, not block, before a build and then yell at them on build failure. I think it is also fair to limit patches to supported releases but rude to drop them on EOL day. Many ports would still work fine. Breaking the framework is different. --=20 Regards, Bryan Drewery --------------A8C5A05EC0328B6279B2CFCD-- --dhSY4123DpLhUsaLrSVFYadNEoRbRx72e-- --RC1lmUz7EBdPmReWQJi2J0fUx1AyVD6Wx Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAl+3AAYFAwAAAAAACgkQNddxu25Gl88t bgf/emwB+QH0XGVryr9MumMVoJusWHqDnwCvKGFk5Q1EIm93Rm00TdF7WnR4hZsvSapfoMiutcRa MpJwMbafWcR5VGBlfAnqQ9g0y+eTH8QbtwUlyhwAxKm1ktjNWvqQAZ4SVR/hhUtbkwIw0yjzMsZF ihesGd1EK0ZIdoy734xa6SD4nd75KpFuSk8KhuIBdW28KZbj7pGXC0FU99jgbrpLOfGUyAAuf1/k HR2lcI40l2hVIwoUiDrkPwACBK/pD5c5Ssqz2HjCoTGt4k37QHrsY/D5huSFHHzt8qcJW8Uz1sXN 9+cqePYZDDkSTM5alfG9/mreWt5lxtvMK0/oz+YMIA== =z3rD -----END PGP SIGNATURE----- --RC1lmUz7EBdPmReWQJi2J0fUx1AyVD6Wx--