From owner-freebsd-git@freebsd.org Mon Dec 21 17:33:59 2020 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9DAAF4C046E for ; Mon, 21 Dec 2020 17:33:59 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D065g3wddz3s7q for ; Mon, 21 Dec 2020 17:33:59 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x731.google.com with SMTP id z11so9453539qkj.7 for ; Mon, 21 Dec 2020 09:33:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uJwuuEgpjbCoxKWFGUUSnjBJuK2IHtGFUOkgZfSUaLM=; b=WQhjWDGx4LYpe96HVCmlsyYpBTKnsWCsanhNyI9WuAmeD6xZ2Dg3jaTEqZZaJsWIML PHFt5BdjVyGe3Dh+8YzuP0HF5MkVRX4YEo/wnw5QShHYhR5N7jUA3znQrf6+QQgogeiM rkxiZwWnyWGUPGsygx/d9h2WlWo2FN4yNNjqg2zZbSsqHpvAV6q8np2Yp4B6y2a1FofZ iP0CouE9xjYodjnShPgSKhjS0rNS3olAhHpAZwQ6GGoq8MzuwylDzVgQC7e5ajydkfHm 0KP5T9kNeqrYyLHFUpWcPfYukM/Uh2d6YM1dwXuc+PqEKoC6TJwEYWAxoGhd1TYXrYcN UGWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uJwuuEgpjbCoxKWFGUUSnjBJuK2IHtGFUOkgZfSUaLM=; b=mZgMEKSV1q5GVPWdqQJCQLxMDE/4K0dlirB2izlYwDxGQasth7kyTTFq4upTU+/Fpg U801WIRn8jMakzgwy4IikdWHbxlCcJMoNRJEaQaDnoJJPLMlgSLq2U2ckjcZbzqiQ1/7 bMz6W+w3P3bWCpw6nOT3xud5xAKCxsyQ1Ge3NGd1tGltXQTAV1nA6Ow+qde4eeMnDRIS a9U36qnRxDqmM5t1Pa4ZRz8o7hihjLloDlk3g03gR9A6al5oVr3v/NOg+VQ0EeJkfxxm F8NrDPilgzJDHsaisGS6eR/v62q7Mli7K2nPkwkdVPsBtrg4UFi3nthGQS4U7OhG0oJ5 lpiQ== X-Gm-Message-State: AOAM531CalOozrKVd7pWZs5edbJTKrZTlffhQKuivenW9ZXkR6bVChOq pRuDsuT9GiNOCLrOBYZaSw1B8wtl+YDRe1GrvnQXjw== X-Google-Smtp-Source: ABdhPJw53/CBE4hyyAmtX+XS9k4Ybu6cMvu8W+DR1t11BzFybGFlX40o3Swszu8jzP0l+lODQZQd+tCz5XyXa8tUhWc= X-Received: by 2002:a37:306:: with SMTP id 6mr17476320qkd.206.1608572038915; Mon, 21 Dec 2020 09:33:58 -0800 (PST) MIME-Version: 1.0 References: <5398f806-42a5-560e-a22c-c5483a0c6f9e@FreeBSD.org> In-Reply-To: <5398f806-42a5-560e-a22c-c5483a0c6f9e@FreeBSD.org> From: Warner Losh Date: Mon, 21 Dec 2020 10:33:48 -0700 Message-ID: Subject: Re: Git commit message templates To: John Baldwin Cc: Ed Maste , freebsd-git X-Rspamd-Queue-Id: 4D065g3wddz3s7q X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 17:33:59 -0000 On Mon, Dec 21, 2020 at 10:28 AM John Baldwin wrote: > On 12/17/20 12:58 PM, Ed Maste wrote: > > On Wed, 16 Dec 2020 at 17:35, John Baldwin wrote: > >> > >> The only one I'm not a fan of is the lack of punctuation for the first > >> sentence. Newspaper headlines also use additional capitalization > >> (e.g. last word and "significant words"), so the current recommendation > >> is a mix of things and not fully consistent with either one. > > > > Fair point - considering the first line as one would an email subject > > is probably the best approach. > > I agree. Perhaps just say that (rather than newspaper headline) and leave > off the note about punctuation. > Personally, I think we're starting to get a bit over prescriptive here. Once you have the length down, and have a keyword at the start, you've got 99% of the benefit. Nobody cares if there's a dot at the end or not, and it's presence or absence adds no value to other readers. Nobody cares about having lots of caps or not. We should just let people use their judgement. Warner