From owner-freebsd-net@FreeBSD.ORG  Thu Jul  8 21:53:59 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2EC3C1065673
	for <net@freebsd.org>; Thu,  8 Jul 2010 21:53:59 +0000 (UTC)
	(envelope-from jfvogel@gmail.com)
Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com
	[209.85.161.182])
	by mx1.freebsd.org (Postfix) with ESMTP id D8FBE8FC19
	for <net@freebsd.org>; Thu,  8 Jul 2010 21:53:58 +0000 (UTC)
Received: by gxk24 with SMTP id 24so988096gxk.13
	for <net@freebsd.org>; Thu, 08 Jul 2010 14:53:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:received:in-reply-to
	:references:date:message-id:subject:from:to:cc:content-type;
	bh=ibxhPmqjlAqHA+tKDx2MknFZJo8U41E1jwwmRt5LYeQ=;
	b=TRH5iQGJPtaCT2SOFyjIpRkjXtvfjREGAG0rldYIojPGSn3h87wGJGGzht98u5UwcF
	AZaLJ42l2wOS1WNJp851NatFQ6pFT6aHolyGyj97YrcDnjuRBZMfsj4ww1YIFC1TsSu0
	VoAmTE5NV2tUrRQ4ZrJlG67Z1Cuz17k67Ae3A=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=nWUEAW4tTtTy2UdeDqLZJ+WtbL8sq+l9OItnpWjIvsnv1sNHB0KNTNi2gWpIVlgkJH
	EYFpDBkgFSdfiTqAN2+HkzfCak4vPu5qMJpjKecT3qStpO0bvhC0HDkRctv9jiTu1pz5
	iQkbJZRFRk3BpYzIEvRK8JF/HojjxEB4lgZ8M=
MIME-Version: 1.0
Received: by 10.229.221.137 with SMTP id ic9mr5408944qcb.209.1278626035536; 
	Thu, 08 Jul 2010 14:53:55 -0700 (PDT)
Received: by 10.229.220.5 with HTTP; Thu, 8 Jul 2010 14:53:55 -0700 (PDT)
In-Reply-To: <AANLkTilRMW4DTpxS_4n_37QGfdiUdJL_UTCgcq3un_mK@mail.gmail.com>
References: <4C3631F4.4090504@gmail.com>
	<AANLkTinc2xB3CAFKZLfVd5wSss6wBQe-qwqVOih--4MN@mail.gmail.com>
	<AANLkTilRMW4DTpxS_4n_37QGfdiUdJL_UTCgcq3un_mK@mail.gmail.com>
Date: Thu, 8 Jul 2010 14:53:55 -0700
Message-ID: <AANLkTilkLdIt7Z8JMK_zDyiPYxjhTKEuuDBHpRrcavQe@mail.gmail.com>
From: Jack Vogel <jfvogel@gmail.com>
To: Chris Buechler <cbuechler@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: net@freebsd.org
Subject: Re: page fault in igb on 8.1
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jul 2010 21:53:59 -0000

There is one case in igb_dma_malloc() where its still IGB_DBA_ALIGN, but the
cases where its allocating TX and RX bufs the alignment is 1, that code is
the
same in 8.1, or head as far as I can see.

Jack


On Thu, Jul 8, 2010 at 2:36 PM, Chris Buechler <cbuechler@gmail.com> wrote:

> On Thu, Jul 8, 2010 at 5:03 PM, Jack Vogel <jfvogel@gmail.com> wrote:
> > Am confused, does not the code in 8.1 have that fix, looked to me like it
> > did?
> >
>
> Maybe I'm confused, but it looks like RELENG_8_1 has the IGB_DBA_ALIGN
> rather than 1.
>
> -                IGB_DBA_ALIGN, 0,    /* alignment, bounds */
> +                1, 0,            /* alignment, bounds */
>
>
> http://svn.freebsd.org/viewvc/base/releng/8.1/sys/dev/e1000/if_igb.c?revision=209145&view=markup
>
> It was reverted back in this commit.
>
> http://svn.freebsd.org/viewvc/base/releng/8.1/sys/dev/e1000/if_igb.c?r1=205283&r2=206211
>
> Chris
>