From owner-svn-src-stable@freebsd.org Tue Dec 3 17:00:35 2019 Return-Path: Delivered-To: svn-src-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D57A41B5C36 for ; Tue, 3 Dec 2019 17:00:35 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47S7XM4Bprz4dLs for ; Tue, 3 Dec 2019 17:00:35 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1575392434; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=wONFw9wBDoKYXDaZqllah+3qGvk6GWe82kF0D4E5vgacIccfO2G5YJhMqzrgSo1b8ZkG73FsxHTFb 3HSxrLNJrKgl+rutL9ae/P/hzJMikE1Wq0AiBjUedF5QgI3eV+Iq5kIs9usFtS5WtqG0mFuNbk3NV5 4Ykrl8nKdsLlewPw9yffo4AsMqVzqA3SqU2XPwAFrVh1XDw3MtZsI1rV6NCzAO9z6bGNTt7doftiu8 56x/nDPxlZucevTFU/wt5wb9nw+9XabZ3JK0yqncDMmMwiXCqtVEUgnO4WaV8wwtsfHhgDlDiSjP5p RTegGmekYxwRHWGRqKAEOSAB3KMBE/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=KafL3a0EFxRKXs7cUc2ZtU0uM4lUtociBjkQiqbPaGg=; b=MEAEal4eU4XtVp3p0eTD7yDZy8AC7GFDHo7vf9xtrh5mf/keX5cGdK4Us4thLD1/blDt0CFRPmS+e pEG3jwJUQE2Lnp6KscJg7zoJYLkXqfpGMoGXnyuZgWIcxbC+CB5mE3jn7f9mH3wpJTqd7H15CvpMoA Z422EETjCS4casanYDpvoIfZa9hNIlt7nA+gonVcuxSmV6B1rOnxoZByhta49F3Hys2GH0mo+UwxcK ak8ElAr2lgFDI3ZMRyAVGC695pw6nMUWdXEXzpSQqtHV+RjJrIjVy/3qscpjkmRZ0E4YQMgFEOgE7R 6PtYnYI4Qn3vREZ1ggdbjTmIPNCkFOw== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=KafL3a0EFxRKXs7cUc2ZtU0uM4lUtociBjkQiqbPaGg=; b=xG0ewZpueYg0mHO+U2lub5HtPNLX+BX1Wvkvyp5r/4gUw94F8txFseo3bW/9O67XTGU3F2jLnvfWl 7yoUSLuMIKfI5iG7kTuvL4mKdma+Q5O3mJJI5HickAhrmN6Szw/iGUy9kAzk3wTYLE8mv1Lo6M6u57 yojffL96cLK79ZZrWXxia/7lX/qs1SjvxYJ4sv1JkkGbNpUqC6Dd10XsczdxiEqTXI11/TsLHOMlIm xKba5VuDQafarPXfJdcbodHnbeaLVLtcMA2umgNjSrh0rG+SSs0wI9/eqkfsIfjGnBzjNL+Hm03gEO 5n6/qGmPLD2b4H3q573fiXvr9YD9rhA== X-MHO-RoutePath: aGlwcGll X-MHO-User: 6a7cf7ee-15ee-11ea-b80c-052b4a66b6b2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 6a7cf7ee-15ee-11ea-b80c-052b4a66b6b2; Tue, 03 Dec 2019 17:00:33 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id xB3H0VIs000276; Tue, 3 Dec 2019 10:00:32 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1dbc23eac25b2c0cece884fc54734e02868d75c6.camel@freebsd.org> Subject: Re: svn commit: r355333 - stable/12/sys/cam From: Ian Lepore To: Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Date: Tue, 03 Dec 2019 10:00:31 -0700 In-Reply-To: <1c18cdbb-2a6e-3cbb-048b-8f1f49a4cef5@FreeBSD.org> References: <201912031642.xB3GgXRD089746@repo.freebsd.org> <1c18cdbb-2a6e-3cbb-048b-8f1f49a4cef5@FreeBSD.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47S7XM4Bprz4dLs X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.90 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.96)[-0.965,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US]; NEURAL_HAM_LONG(-0.93)[-0.934,0] X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Dec 2019 17:00:35 -0000 On Tue, 2019-12-03 at 11:54 -0500, Alexander Motin wrote: > On 03.12.2019 11:47, Ian Lepore wrote: > > On Tue, 2019-12-03 at 16:42 +0000, Alexander Motin wrote: > > > Author: mav > > > Date: Tue Dec 3 16:42:32 2019 > > > New Revision: 355333 > > > URL: https://svnweb.freebsd.org/changeset/base/355333 > > > > > > Log: > > > MFC r341756 (by scottl): > > > Don't allocate the config_intrhook separately from the softc, > > > it's > > > small > > > enough that it costs more code to handle the malloc/free than > > > it > > > saves. > > > > > > > If it's a situation where the called hook routine always does a > > disestablish of the hook (and nothing else does so), just use > > config_intrhook_oneshot() and you don't need to manage the data > > struct > > yourself at all. > > Right. That is what I have done in my later commit. The only downside > of config_intrhook_oneshot() is that it require memory allocation unlike > previous. > Yeah, it's all about convenience rather than peformance. Usually when I need an intrhook it's a "one device instance once at bootup" kind of thing where performance doesn't matter much. -- Ian