Date: Sun, 29 Sep 2013 17:58:13 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Alexey Dokuchaev <danfe@nsu.ru> Cc: FreeBSD Stable Mailing List <freebsd-stable@freebsd.org>, Bernhard Schmidt <bschmidt@freebsd.org> Subject: Re: panic with if_iwi(4) upon "netif restart" Message-ID: <CAJ-VmonQzegTc%2B%2B50focLNck06ywHp2gNFwutM4T42qsYVZddQ@mail.gmail.com> In-Reply-To: <20130929170346.GA24786@regency.nsu.ru> References: <20120507035405.GA47351@regency.nsu.ru> <CAAgh0_aS-7EvM1QgQzOgUF4Hqhd3w394nxw=vzB6b-e2AeUe6A@mail.gmail.com> <20120619052810.GA40402@regency.nsu.ru> <201207041851.56283.bschmidt@freebsd.org> <20130929170346.GA24786@regency.nsu.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Sure, uhm, just remind me to commit it to -HEAD in the next few days. Then I'll get it backported to stable/9. Thanks, -adrian On 29 September 2013 10:03, Alexey Dokuchaev <danfe@nsu.ru> wrote: > On Wed, Jul 04, 2012 at 06:51:56PM +0200, Bernhard Schmidt wrote: > > On Tuesday 19 June 2012 07:28:11 Alexey Dokuchaev wrote: > > > On Mon, May 07, 2012 at 08:28:50PM +0200, Bernhard Schmidt wrote: > > > > does "ps" in kgdb reveal multiple instances of wpa_supplicant > running? > > > > If so, this seems to be the well known devd+netif+supplicant+newstate > > > > race/missing refcount. > > > > > > > > Wanna try attached patch? > > > > > > Bernhard, > > > > > > Sorry it took so long to get back. With your patch applied, I haven't > > > seen this panic for a while, however, double instances of > wpa_supplicant > > > still persist. So I think you can commit it, but underlying race > remains > > > to be fixed. > > > > Ok, thanks. The patch is indeed supposed to only fix the panics. > > > > The underlying problem is that a "netif restart" results in 2 > > calls to "netif wlan0 start", one through the call itself the other > > due an event sent to devd. wpa_supplicant itself has a small window > > were it is possible that 2 instances are attached to one resource. > > I have yet to find a solution for this without adding any regressions. > > Funny thing: I've just tried 9-stable on this laptop of mine, and it > paniced immediately inside iwi_auth_and_assoc() again once I've run > wpa_supplicant (this time I did not do any of "netif restart" dances). > > Applying the same patch fixed it for me and allowed to have working > network (typing through it right now). > > Haven't tried -current yet, but it looks like iwi(4) is unusable at least > in 9.2. Can we have this patch committed while real solution is being > worked on? It looks like it's going to take a while, and I'd like to have > working iwi(4) like, uhm, now. ;-) > > ./danfe > _______________________________________________ > freebsd-stable@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmonQzegTc%2B%2B50focLNck06ywHp2gNFwutM4T42qsYVZddQ>