From nobody Sun Apr 26 08:07:23 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g3K6z3FN5z6bDDT for ; Sun, 26 Apr 2026 08:07:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g3K6z1ZF2z45LT for ; Sun, 26 Apr 2026 08:07:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777190843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CocMVcB5WDdhdCYiH8oEHy+/H96OtlUsH2i5F5c25jk=; b=b3vdzhTDIcBcnA7yr8dPS00x/thmre5yQKd7Y3CZ9hzhqbEaOtXLMcWGov6FS104orcztx 96FdztEOGzEgh5xzrsUeP3gnEnhwZsM7k9ZlUZCInSk7Pdv+CaaxUSQk7I9Mduz3nq8x7q otmFGo3tlOD6aoYY53T+FznTjZB+Jm+teUJxChOp6+x9XxdO6DVZHnno0IA/K8NYRpozUu oS8A5JHVXEAjPmfS0ze7AO9eV6gI5blbJ7J100mIMPgOb73rztRoheV1cb72+qx71eMYXZ an/FQdggVo1iclVoaF8fp6Tu3hq6O2O6VujuP3tnemdOo34Ly29VDtGgEfrBNg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777190843; a=rsa-sha256; cv=none; b=XVlXKei7JaIDWNLjWhzULoqGELLnfGOVLn3uZ7qYV8EmiaZY4PcC2x+fRypXzXbDZ7RAUk bb10nkixDucQl3CbZIk+ovCDNJ3bSkcLp8w/S7rMyRVQU96FoE63M/2QYVO/2629kC5Fry 7vcB1OHFMazccMgZCcCZ7eKiwK+se8igKgYRMpWTKMDr0f/XTXsa3Eh7j21v5yA+c+BFne hHCmOihWhHc42UHFP2Vuoyfccz1QO8bSBU313HuNsY8UHtkXjHP3/f+4VAaMyImCZOkEFW lfI1GCvnmz7BduP5zDZ74oW6VC0qjAN3EGVlZdKSXtA05aQVCYDSHlf/yH2+NA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777190843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CocMVcB5WDdhdCYiH8oEHy+/H96OtlUsH2i5F5c25jk=; b=m94hmy57NwXLd8wSdYEGX3IhxkS/esaLo57saqPe/MquTRb3ijepfquemkb75TcvrbUIf6 6ap1X5D8/N2ClmP4zooD05Lv3oZoLfA5RabW0s+okDLM696N7XB7ywMTFiPtNO9HX4zijA js9LzdeK4ZmxCInNa99xhgxfpcYo76bgYFo+WPc3O408fESjsgcoQyv3+YoXu9FET+NEEK K6LyIN1+tPnlFb8vUMTXtkjZboeV7m6bt1wbJ+VuVnM2qPrm8zFfHIyFCErqfqUPhMVHmy k4Y6txqZTy+PymffTiIYWM41+IYk8Dfy31r22j/324wgNVLFJSVUwjuKO3lh4Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g3K6z14gWz19Xn for ; Sun, 26 Apr 2026 08:07:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26ad2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 26 Apr 2026 08:07:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: d3e3c9a93b77 - stable/15 - tcp: retire TF_SENTSYN List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: d3e3c9a93b771fa2b531eb7c586e68ad2326823d Auto-Submitted: auto-generated Date: Sun, 26 Apr 2026 08:07:23 +0000 Message-Id: <69edc7bb.26ad2.59e559c1@gitrepo.freebsd.org> The branch stable/15 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=d3e3c9a93b771fa2b531eb7c586e68ad2326823d commit d3e3c9a93b771fa2b531eb7c586e68ad2326823d Author: Michael Tuexen AuthorDate: 2026-04-03 19:22:11 +0000 Commit: Michael Tuexen CommitDate: 2026-04-26 08:05:33 +0000 tcp: retire TF_SENTSYN This TF_-flag is only used in the RACK stack and not really needed. So replace it, since glebius@ needs a TF_ flag and right now all of them are taken. No functional change intended. Reviewed by: rrs, glebius, rscheff, Nick Banks Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D56025 Event: Wiesbaden Hackathon 2024 (cherry picked from commit 32cc4beb0a8c3cadc0de4c255ba512fd7b196607) --- sys/netinet/tcp_stacks/rack.c | 4 +--- sys/netinet/tcp_var.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index 9bc4530afe10..219cf2758ff2 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -22031,10 +22031,8 @@ out: * Now for special SYN/FIN handling. */ if (flags & (TH_SYN | TH_FIN)) { - if ((flags & TH_SYN) && - ((tp->t_flags & TF_SENTSYN) == 0)) { + if ((flags & TH_SYN) != 0 && tp->snd_max == tp->iss) { tp->snd_max++; - tp->t_flags |= TF_SENTSYN; } if ((flags & TH_FIN) && ((tp->t_flags & TF_SENTFIN) == 0)) { diff --git a/sys/netinet/tcp_var.h b/sys/netinet/tcp_var.h index f9297be46af7..9d1d2bd31674 100644 --- a/sys/netinet/tcp_var.h +++ b/sys/netinet/tcp_var.h @@ -789,7 +789,7 @@ tcp_packets_this_ack(struct tcpcb *tp, tcp_seq ack) #define TF_TSO 0x01000000 /* TSO enabled on this connection */ #define TF_TOE 0x02000000 /* this connection is offloaded */ #define TF_CLOSED 0x04000000 /* close(2) called on socket */ -#define TF_SENTSYN 0x08000000 /* At least one syn has been sent */ +#define TF_UNUSED 0x08000000 /* was TF_SENTSYN */ #define TF_LRD 0x10000000 /* Lost Retransmission Detection */ #define TF_CONGRECOVERY 0x20000000 /* congestion recovery mode */ #define TF_WASCRECOVERY 0x40000000 /* was in congestion recovery */ @@ -803,7 +803,7 @@ tcp_packets_this_ack(struct tcpcb *tp, tcp_seq ack) "\15TF_NOPUSH\16TF_PREVVALID\17TF_WAKESOR\20TF_GPUTINPROG" \ "\21TF_MORETOCOME\22TF_SONOTCONN\23TF_LASTIDLE\24TF_RXWIN0SENT" \ "\25TF_FASTRECOVERY\26TF_WASFRECOVERY\27TF_SIGNATURE\30TF_FORCEDATA" \ - "\31TF_TSO\32TF_TOE\33TF_CLOSED\34TF_SENTSYN" \ + "\31TF_TSO\32TF_TOE\33TF_CLOSED\34TF_UNUSED" \ "\35TF_LRD\36TF_CONGRECOVERY\37TF_WASCRECOVERY\40TF_FASTOPEN" #define IN_FASTRECOVERY(t_flags) (t_flags & TF_FASTRECOVERY)