From owner-cvs-all Sun Jan 12 0:11:22 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2342237B401; Sun, 12 Jan 2003 00:11:21 -0800 (PST) Received: from magic.adaptec.com (magic.adaptec.com [208.236.45.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7376943ED8; Sun, 12 Jan 2003 00:11:20 -0800 (PST) (envelope-from scott_long@btc.adaptec.com) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6+Sun/8.11.6) with ESMTP id h0C8Awj27519; Sun, 12 Jan 2003 00:10:58 -0800 (PST) Received: from btc.btc.adaptec.com (btc.btc.adaptec.com [10.100.0.52]) by redfish.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id AAA04969; Sun, 12 Jan 2003 00:10:52 -0800 (PST) Received: from btc.adaptec.com (hollin [10.100.253.56]) by btc.btc.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id BAA15607; Sun, 12 Jan 2003 01:10:47 -0700 (MST) Message-ID: <3E2122F6.70400@btc.adaptec.com> Date: Sun, 12 Jan 2003 01:10:30 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.2b) Gecko/20021105 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Alfred Perlstein Cc: Jake Burkholder , Matthew Dillon , cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_acl.c kern_descrip.c kern_event.c kern_mac.c sys_pipe.c sys_socket.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c vfs_aio.c vfs_syscalls.c vfs_vnops.c src/sys/netgraph ng_socket.c src/sys/sys file.h src/sys/ufs/ffs ... References: <200301120137.h0C1bD0E098037@repoman.freebsd.org> <20030111213259.E212@locore.ca> <200301120254.h0C2srcS043241@apollo.backplane.com> <20030112014644.F212@locore.ca> <20030112075042.GE33821@elvis.mu.org> In-Reply-To: <200301120137.h0C1bD0E098037@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Alfred Perlstein wrote: > * Jake Burkholder [030111 22:46] wrote: > > >Its unnecessary code churn. I wouldn't be surprised if struct file was > >used all the place in 3rd party modules, especially MAC modules. Now > >they either need an ugly compat define or ugly idfefs. Some of your > commits > >were to code that's externally maintained. We've broken > compatibility with > >external code before for compelling reasons. This is not a > compelling reason. > > > >You obviously don't think this is important, I do. If no one else > cares about > >this I'll shut up now. > > > I prefer Jake's idea of just removing the casts where they are unneeded. > > This adds unneeded complexity and renaming that we don't need. > > It also reduces diffs to what will be 5-stable. > With an re@ hat on, I agree with Alfred. When RELENG_5_0 was branched we asked that gratuitous changes and API, ABI, etc changes be kept to a minimum and that re@ be consulted before doing them. Cleaning up the code is fine, changing the names and types of structure members in the API goes against the spirit of what was requested. Please revert your changes to sys/sys/file.h. Scott To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message