From owner-freebsd-bugs@FreeBSD.ORG Mon Apr 17 04:00:38 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AE2C16A426 for ; Mon, 17 Apr 2006 04:00:38 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B0AB443D46 for ; Mon, 17 Apr 2006 04:00:37 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k3H40W24012455 for ; Mon, 17 Apr 2006 04:00:32 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k3H40WSR012448; Mon, 17 Apr 2006 04:00:32 GMT (envelope-from gnats) Resent-Date: Mon, 17 Apr 2006 04:00:32 GMT Resent-Message-Id: <200604170400.k3H40WSR012448@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, leres@ee.lbl.gov (Craig Leres) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 107CB16A405 for ; Mon, 17 Apr 2006 03:59:59 +0000 (UTC) (envelope-from leres@ee.lbl.gov) Received: from fun.ee.lbl.gov (fun.ee.lbl.gov [131.243.1.81]) by mx1.FreeBSD.org (Postfix) with ESMTP id 86AC543D48 for ; Mon, 17 Apr 2006 03:59:58 +0000 (GMT) (envelope-from leres@ee.lbl.gov) Received: from fun.ee.lbl.gov (localhost [127.0.0.1]) by fun.ee.lbl.gov (8.13.6/8.13.6) with ESMTP id k3H3xwv9016954 for ; Sun, 16 Apr 2006 20:59:58 -0700 (PDT) Received: from fun.ee.lbl.gov (leres@localhost) by fun.ee.lbl.gov (8.13.6/8.13.6/Submit) with ESMTP id k3H3xwcG016951 for ; Sun, 16 Apr 2006 20:59:58 -0700 (PDT) Message-Id: <200604170359.k3H3xwcG016951@fun.ee.lbl.gov> Date: Sun, 16 Apr 2006 20:59:58 -0700 From: leres@ee.lbl.gov (Craig Leres) To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: conf/95905: [PATCH] /etc/rc.d/dhclient doesn't interact well with the ports isc dhcp client X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Apr 2006 04:00:38 -0000 >Number: 95905 >Category: conf >Synopsis: [PATCH] /etc/rc.d/dhclient doesn't interact well with the ports isc dhcp client >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Apr 17 04:00:31 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Craig Leres >Release: FreeBSD 6.1-BETA4 i386 >Organization: Lawrence Berkeley National Laboratory >Environment: fox 15 % uname -a FreeBSD fox.ee.lbl.gov 6.1-BETA4 FreeBSD 6.1-BETA4 #1: Fri Apr 14 01:03:21 PDT 2006 leres@fox.ee.lbl.gov:/usr/src/6.1-BETA4/sys/i386/compile/LBLSMP i386 fox 16 % pkg_info | grep isc-dhcp3-client isc-dhcp3-client-3.0.3_1 The ISC Dynamic Host Configuration Protocol client >Description: The test in /etc/rc.d/dhclient that is supposed to prevent dhclient from being launched if one is already running doesn't work with the ports version of dhclient. If you have an interface configured for dhcp in /etc/rc.conf, dhclient runs and gets a lease normally but then is run again later at which point it sets the interface address to 0.0.0.0, ending network access via that NIC. >How-To-Repeat: Install the isc-dhcp3-client and configure a NIC to use it: ifconfig_em0="dhcp" Then reboot. The interface will come up when dhclient runs. Later when it's run again, you'll see this message: Internet Systems Consortium DHCP Client V3.0.3 Copyright 2004-2005 Internet Systems Consortium. All rights reserved. For info, please visit http://www.isc.org/products/DHCP Listening on BPF/em0/00:30:48:00:00:01 Sending on BPF/em0/00:30:48:00:00:01 Can't bind to dhcp address: Address already in use Please make sure there is no other dhcp server running and that there's no entry for dhcp or bootp in /etc/inetd.conf. Also make sure you are not running HP JetAdmin software, which includes a bootp server. At this point the original dhclient is still running but the interface is misconfigured and you're hosed. >Fix: The simplest solution is to check /var/run/dhclient.pid in addition doing the pgrep test that's already in the rc script. The appended patch implements this. A more complete solution would be to also change the base version of dhclient to manage the /var/run/dhclient.pid file and remove the pgrep test from the rc.d script. (If there is interest in that, I'd be happy to generate the diffs.) *** dhclient 2006/04/17 02:59:17 1.1 --- dhclient 2006/04/17 03:35:20 *************** *** 27,32 **** --- 27,42 ---- fi fi + # deal with isc dhclient too + f="/var/run/dhclient.pid" + if [ -s ${f} ]; then + pid="`cat ${f}`" + kill -0 "${pid}" >/dev/null 2>&1 + if [ $? -eq 0 ]; then + exit 0 + fi + fi + if checkyesno background_dhclient; then rc_flags="${rc_flags} -b" fi >Release-Note: >Audit-Trail: >Unformatted: