From owner-freebsd-net@FreeBSD.ORG Sat Jun 13 08:26:13 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C30C1065678 for ; Sat, 13 Jun 2009 08:26:13 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from dvz-002.fh-muenster.de (mail.FH-Muenster.DE [193.174.88.2]) by mx1.freebsd.org (Postfix) with ESMTP id C7C718FC0C for ; Sat, 13 Jun 2009 08:26:12 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from localhost (localhost.localdomain [127.0.0.1]) by dvz-002.fh-muenster.de (Postfix) with ESMTP id 52F051CC5C5; Sat, 13 Jun 2009 10:24:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at dvz-002.fh-muenster.de X-Spam-Score: -3.977 X-Spam-Level: X-Spam-Status: No, score=-3.977 tagged_above=-999 required=6.31 tests=[ALL_TRUSTED=-1.665, BAYES_00=-2.312] Received: from dvz-002.fh-muenster.de ([127.0.0.1]) by localhost (dvz-002.fh-muenster.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aY7zStaIp6nZ; Sat, 13 Jun 2009 10:24:08 +0200 (CEST) Received: from [192.168.1.100] (p508FEA6E.dip.t-dialin.net [80.143.234.110]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client did not present a certificate) (Authenticated sender: tuexen) by dvz-002.fh-muenster.de (Postfix) with ESMTP id 53ABE1CC5B5; Sat, 13 Jun 2009 10:24:08 +0200 (CEST) Message-Id: <7472C82E-0C52-45AB-9BFF-DD6196B393C9@freebsd.org> From: Michael Tuexen To: pyunyh@gmail.com In-Reply-To: <20090613080136.GB76872@michelle.cdnetworks.co.kr> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Sat, 13 Jun 2009 10:26:09 +0200 References: <20090611184555.J22887@maildrop.int.zabbadoz.net> <20090612013406.GB72855@michelle.cdnetworks.co.kr> <20090612100900.M22887@maildrop.int.zabbadoz.net> <71535CB2-2784-4253-B67E-017FEAD57637@freebsd.org> <4A32F752.90003@cs.duke.edu> <20090613080136.GB76872@michelle.cdnetworks.co.kr> X-Mailer: Apple Mail (2.935.3) Cc: FreeBSD net mailing list , Andrew Gallatin Subject: Re: Ethernet NIC drivers depending unconditionally on INET X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2009 08:26:13 -0000 On Jun 13, 2009, at 10:01 AM, Pyun YongHyeon wrote: > On Sat, Jun 13, 2009 at 09:15:06AM +0200, Michael Tuexen wrote: >> On Jun 13, 2009, at 2:48 AM, Andrew Gallatin wrote: >> >>> Michael Tuexen wrote: >>> >>>> I'm not sure if we need additional IFCAP_RXCSUM6 IFCAP_TXCSUM6 >>>> capabilities... Why would we want to enable IPv4 offloading and >>>> not IPv6 or vice versa? >>> >>> I'd assume that some older hardware supports IPv4 offloads, but >>> might not have support for IPv6 offloads. >> Sure. But then the driver only provides the CSUM_ flags which >> are appropriate. For example, a similar thing is already in the >> igb driver: >> >> 1167 if (ifp->if_capenable & IFCAP_TXCSUM) { >> 1168 ifp->if_hwassist |= (CSUM_TCP | CSUM_UDP); >> 1169 #if __FreeBSD_version >= 800000 >> 1170 if (adapter->hw.mac.type == e1000_82576) >> 1171 ifp->if_hwassist |= CSUM_SCTP; >> 1172 #endif >> 1173 } > > That would disable all IPv4/IPv6 checksum offloading if > administrator disable IFCAP_TXCSUM. If we have IFCAP_TXCSUM6/ > IFCAP_RXCSUM6 users could choose best working one even if some part > of driver/controller had checksum offload bugs. Sure. That is what I wrote in my earlier mail: Do we want to provide a ability to disable/enable checksum offload for IPv4 and IPv6 individually... Besides this "working around bugs" I see no reason to do it. Some other capabilities TSO/TOE are IPv[46] specific. I have no strong opinion on this. What do others think? Best regards Michael > >> >> For FreeBSD 8 and a particular chip, SCTP checksum offloading >> is supported. No need for a special IFCAP_TXCSUM. >> >> Best regards >> Michael >> >>> >>> Drew >>