From owner-freebsd-emulation Thu Sep 2 11:22:25 1999 Delivered-To: freebsd-emulation@freebsd.org Received: from gaia.euronet.nl (gaia.euronet.nl [194.134.0.10]) by hub.freebsd.org (Postfix) with ESMTP id 3E8A2155E5 for ; Thu, 2 Sep 1999 11:22:19 -0700 (PDT) (envelope-from marcel@scc.nl) Received: from scones.sup.scc.nl (i208.ztm.euronet.nl [194.134.67.9]) by gaia.euronet.nl (8.8.8/8.8.8) with ESMTP id UAA08499; Thu, 2 Sep 1999 20:22:15 +0200 (MET DST) Received: from scc.nl (scones.sup.scc.nl [192.168.2.4]) by scones.sup.scc.nl (8.9.3/8.9.3) with ESMTP id UAA27349; Thu, 2 Sep 1999 20:22:13 +0200 (CEST) (envelope-from marcel@scc.nl) Message-ID: <37CEC055.3DEF49D@scc.nl> Date: Thu, 02 Sep 1999 20:22:13 +0200 From: Marcel Moolenaar Organization: SCC vof X-Mailer: Mozilla 4.61 [en] (X11; I; Linux 2.2.5 i386) X-Accept-Language: en MIME-Version: 1.0 To: Luoqi Chen Cc: emulation@FreeBSD.ORG Subject: Re: Minor changes to USER_LDT related code References: <199909021738.NAA26555@lor.watermarkgroup.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-emulation@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Luoqi Chen wrote: > > 1) Don't make i386_get_ldt and i386_set_ldt static so they can be > > used by the linuxulator. > > 2) When ``option USER_LDT'' is not present, provide stubs for the > > functions. These simply return ENOSYS. > > 3) Add the proper prototypes to i386/include/sysarch.h > > > I am in favor of calling generic sysarch() interface instead, it should be > the only API outside world knows about. And there will be no need to do > any of the three items you listed above. Well, I don't like to redefine i386_get_ldt_args or i386_set_ldt_args in the Linuxulator, so I think (3) should be done anyway. Furthermore, using the sysarch() interface when USER_LDT is not defined will return EINVAL and not ENOSYS. That's a bit inconvenient because I can't tell which EINVAL should actually be ENOSYS. As a third remark, a kernel module is hardly "outside world" :-) Anyway, I see your point, but don't think the sysarch interface is what I need. -- Marcel Moolenaar mailto:marcel@scc.nl SCC Internetworking & Databases http://www.scc.nl/ The FreeBSD project mailto:marcel@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-emulation" in the body of the message