Date: Fri, 23 Nov 2018 12:48:45 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Dmitry Marakasov <amdmi3@amdmi3.ru>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r485586 - head/java/netty Message-ID: <20181123124845.GA50746@FreeBSD.org> In-Reply-To: <20181122161928.md57g2b2y7ctvkdb@atuin.in.mat.cc> References: <201811220930.wAM9URj7056367@repo.freebsd.org> <20181122095930.fnfd4gpowkqehznp@atuin.in.mat.cc> <20181122125524.GA37389@hades.panopticon> <20181122161928.md57g2b2y7ctvkdb@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 22, 2018 at 05:19:28PM +0100, Mathieu Arnold wrote:
> On Thu, Nov 22, 2018 at 03:55:24PM +0300, Dmitry Marakasov wrote:
> > * Mathieu Arnold (mat@FreeBSD.org) wrote:
> > > > -PLIST_FILES= %%JAVAJARDIR%%/netty-${PORTVERSION}.jar \
> > > > - %%JAVAJARDIR%%/netty.jar
> > > > +PLIST_FILES= ${JAVAJARDIR:S,^${PREFIX}/,,}/netty-${PORTVERSION}.jar \
> > > > + ${JAVAJARDIR:S,^${PREFIX}/,,}/netty.jar
> > >
> > > This seems overly complicated. What is wrong with having just
> > > ${JAAAVJARDIR}?
> >
> > It contains absolute path. I've assumed we don't use these in the plist.
>
> Paths in the PLIST are either relative to PREFIX or absolute. If a path
> is absolute and starts with PREFIX, it is just fine.
Absolute paths, however, look ugly in PLIST, and generally do not sound
like a good idea (e.g., how well do they align with relocatable packages)?
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181123124845.GA50746>