From owner-svn-src-all@freebsd.org Sat Mar 10 14:36:19 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C43D2F3D24F for ; Sat, 10 Mar 2018 14:36:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3F60376166 for ; Sat, 10 Mar 2018 14:36:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x234.google.com with SMTP id c11so6023675ith.4 for ; Sat, 10 Mar 2018 06:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=jCUdP2C8Lwn2SoR5036EqJYn3tC4YArryirbMBoiy58=; b=WDoRk+yQVqfKcxkm+X5mQqqyTqzKCGZi4z9fY3CMVVPE/AVhvHPTvLzHajF+h1DW5T nhhhzARwJ54Lf9y/7LoT6barWP7gAGCDNxoeoaPhvTZPJ+SPLmDuFI7LTJadtYnnBMqL eHdzFMH8dDizguJK1JP/kHgk/IFC78IaP29CouvKHPwbEjo6m9CVFGFOEoVzOoFL7A// RgYjVBqW+pBIBHTpprQjscNXmzKiSg/K86K9W9hDYDyinqxRiItAk0qNOMrlq6MZ1RLS WRJMPbUymaWVookMDYi0FGxeNnjJ+ybmALSAuNW8pmIc3IXVD1RncaYTAFF0qGOOY/co jfDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=jCUdP2C8Lwn2SoR5036EqJYn3tC4YArryirbMBoiy58=; b=BtAezjJaZDgzqCb3DUGVDeKCrL6gUrvfFIYACQfX0Rp0FpCkg7IxDZarkr5z3SpWmB ncObBXnd5KvSDN5ecCmdcMGRObddHcWApK5Ofo0AbzzB3/myvR4OOxhOtfJ3C/ynpW2m yJxLQEFe/4nNvJfmcbJAwkA6O1Gt7Ncpywbb5k0WAFMmUskXiU9wPkdvb07EU9+UuduU AE2t1ouiJhgb9XJhd/twCXkqeVLJ9oICGwDimOJ7klvyf3KbXnwvk9aOnCbPZwlWXSur A4tAQQX1JzgwyTzbj8JDrssB8HPypq0zutphVXBdIU1P6gvFG3OFVo6/qSDLKyce6AB8 dIRA== X-Gm-Message-State: AElRT7GW3/QHG6/mm/olpXHezhBc+FrOaw1hla0G9qCM17KHF5ycgIdZ biVxxSrSe1Z9adB4kkl4QA57rm8GkkYH7gmgc+nzfA== X-Google-Smtp-Source: AG47ELvx6K0JWkss8cmoT94mhbZvAcM40tT851mhzMLKl13QGhOm3ShV3pCXjDoEA41u2myMrVk/tr7pmw0Ax4M/lHo= X-Received: by 10.36.148.204 with SMTP id j195mr1912063ite.1.1520692577283; Sat, 10 Mar 2018 06:36:17 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.203.196 with HTTP; Sat, 10 Mar 2018 06:36:16 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:18a2:a4f7:170:8dd9] In-Reply-To: <20180310084333.GC18340@FreeBSD.org> References: <201803092132.w29LW8QD030490@repo.freebsd.org> <20180310084333.GC18340@FreeBSD.org> From: Warner Losh Date: Sat, 10 Mar 2018 07:36:16 -0700 X-Google-Sender-Auth: C3FSSJvFL5gKZVB9G0obR2L9Om4 Message-ID: Subject: Re: svn commit: r330705 - head/sbin/mount To: Alexey Dokuchaev Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2018 14:36:19 -0000 On Sat, Mar 10, 2018 at 1:43 AM, Alexey Dokuchaev wrote: > On Fri, Mar 09, 2018 at 09:32:08PM +0000, Warner Losh wrote: > > New Revision: 330705 > > URL: https://svnweb.freebsd.org/changeset/base/330705 > > > > Log: > > Remove decade's old whine about msdos vs msdosfs. > > > > Retain the compatibility silently though. > > Shouldn't it be the other way around? That is, after a decade of whining > people would've updated their configs/scripts and old (deprecated) gimmick > can now be removed? That's what usually implied by "deprecated", right? > Nope. We accept both because even after a decade, people's fingers haven't changed. The original change was poorly socialized and met with scorn at the time. It's better to just accept both as some people have changed and others haven't. The 'deprecated' part never took hold, so I just removed the warning because the consensus is we are never going to stop accepting both. Warner > ./danfe > > > Modified: head/sbin/mount/mount.c > > ... > > @@ -589,11 +589,8 @@ mountfs(const char *vfstype, const char *spec, > const c > > optbuf = catopt(optbuf, "update"); > > > > /* Compatibility glue. */ > > - if (strcmp(vfstype, "msdos") == 0) { > > - warnx( > > - "Using \"-t msdosfs\", since \"-t msdos\" is > deprecated."); > > + if (strcmp(vfstype, "msdos") == 0) > > vfstype = "msdosfs"; > > - } >