Date: Fri, 22 Aug 2014 11:52:42 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, ports-committers@freebsd.org, Hiroki Sato <hrs@FreeBSD.org>, svn-ports-all@freebsd.org, Bryan Drewery <bdrewery@FreeBSD.org> Subject: Re: svn commit: r365590 - in head/cad/spice: . files Message-ID: <20140822115242.GB2378@FreeBSD.org> In-Reply-To: <53F6724A.6000602@marino.st> References: <201408211941.s7LJf6de048334@svn.freebsd.org> <53F663B2.3000800@marino.st> <20140822.070939.1253386656808735449.hrs@allbsd.org> <53F66EE5.7080500@FreeBSD.org> <53F6724A.6000602@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 22, 2014 at 12:27:22AM +0200, John Marino wrote: > In this PARTICULAR case, I staged the port. I fixed that makefile. HRS > changes serve no purpose other than to potentially break my work. > Obviously that is not his intention, but that is the result. > > Frankly he should revert this immediately. It was working before > everywhere. +1. I routinely witness cases of next committer coming and making changes that destroy previous very fine work, most likely without even consulting the guy or checking any past history whatsoever. We should really get into habit of 'svn log'ing and 'svn blame'ing before doing any non-trivial work on a port. Ports should not depend on FreeBSD's src make macros, irregardless of DF support. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140822115242.GB2378>