From owner-svn-src-stable-12@freebsd.org Tue Sep 3 19:52:29 2019 Return-Path: Delivered-To: svn-src-stable-12@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 010C9D5BAC; Tue, 3 Sep 2019 19:52:29 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46NHfh6Ccwz4Gmy; Tue, 3 Sep 2019 19:52:28 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B9BC9822F; Tue, 3 Sep 2019 19:52:28 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x83JqSkJ075946; Tue, 3 Sep 2019 19:52:28 GMT (envelope-from kib@FreeBSD.org) Received: (from kib@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x83JqShj075944; Tue, 3 Sep 2019 19:52:28 GMT (envelope-from kib@FreeBSD.org) Message-Id: <201909031952.x83JqShj075944@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: kib set sender to kib@FreeBSD.org using -f From: Konstantin Belousov Date: Tue, 3 Sep 2019 19:52:28 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r351786 - in stable/12: share/man/man9 sys/sys X-SVN-Group: stable-12 X-SVN-Commit-Author: kib X-SVN-Commit-Paths: in stable/12: share/man/man9 sys/sys X-SVN-Commit-Revision: 351786 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable-12@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for only the 12-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 19:52:29 -0000 Author: kib Date: Tue Sep 3 19:52:28 2019 New Revision: 351786 URL: https://svnweb.freebsd.org/changeset/base/351786 Log: MFC r350204: Switch the rest of the refcount(9) functions to bool return type. Modified: stable/12/share/man/man9/refcount.9 stable/12/sys/sys/refcount.h Directory Properties: stable/12/ (props changed) Modified: stable/12/share/man/man9/refcount.9 ============================================================================== --- stable/12/share/man/man9/refcount.9 Tue Sep 3 19:50:38 2019 (r351785) +++ stable/12/share/man/man9/refcount.9 Tue Sep 3 19:52:28 2019 (r351786) @@ -26,7 +26,7 @@ .\" .\" $FreeBSD$ .\" -.Dd January 20, 2009 +.Dd July 21, 2019 .Dt REFCOUNT 9 .Os .Sh NAME @@ -42,7 +42,7 @@ .Fn refcount_init "volatile u_int *count" "u_int value" .Ft void .Fn refcount_acquire "volatile u_int *count" -.Ft int +.Ft bool .Fn refcount_release "volatile u_int *count" .Sh DESCRIPTION The @@ -73,9 +73,9 @@ protection for acquiring a new reference. The .Fn refcount_release function is used to release an existing reference. -The function returns a non-zero value if the reference being released was +The function returns true if the reference being released was the last reference; -otherwise, it returns zero. +otherwise, it returns false. .Pp Note that these routines do not provide any inter-CPU synchronization, data protection, @@ -89,7 +89,7 @@ is released. .Sh RETURN VALUES The .Nm refcount_release -function returns non-zero when releasing the last reference and zero when +function returns true when releasing the last reference and false when releasing any other reference. .Sh HISTORY These functions were introduced in Modified: stable/12/sys/sys/refcount.h ============================================================================== --- stable/12/sys/sys/refcount.h Tue Sep 3 19:50:38 2019 (r351785) +++ stable/12/sys/sys/refcount.h Tue Sep 3 19:52:28 2019 (r351786) @@ -70,7 +70,7 @@ refcount_acquire_checked(volatile u_int *count) } } -static __inline int +static __inline bool refcount_release(volatile u_int *count) { u_int old; @@ -79,7 +79,7 @@ refcount_release(volatile u_int *count) old = atomic_fetchadd_int(count, -1); KASSERT(old > 0, ("refcount %p is zero", count)); if (old > 1) - return (0); + return (false); /* * Last reference. Signal the user to call the destructor. @@ -88,7 +88,7 @@ refcount_release(volatile u_int *count) * at the start of the function synchronized with this fence. */ atomic_thread_fence_acq(); - return (1); + return (true); } /* @@ -97,7 +97,7 @@ refcount_release(volatile u_int *count) * * A temporary hack until refcount_* APIs are sorted out. */ -static __inline __result_use_check int +static __inline __result_use_check bool refcount_acquire_if_not_zero(volatile u_int *count) { u_int old; @@ -106,13 +106,13 @@ refcount_acquire_if_not_zero(volatile u_int *count) for (;;) { KASSERT(old < UINT_MAX, ("refcount %p overflowed", count)); if (old == 0) - return (0); + return (false); if (atomic_fcmpset_int(count, &old, old + 1)) - return (1); + return (true); } } -static __inline __result_use_check int +static __inline __result_use_check bool refcount_release_if_not_last(volatile u_int *count) { u_int old; @@ -121,9 +121,9 @@ refcount_release_if_not_last(volatile u_int *count) for (;;) { KASSERT(old > 0, ("refcount %p is zero", count)); if (old == 1) - return (0); + return (false); if (atomic_fcmpset_int(count, &old, old - 1)) - return (1); + return (true); } }