From owner-freebsd-bugs@FreeBSD.ORG Mon Mar 26 06:20:09 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 810B11065670 for ; Mon, 26 Mar 2012 06:20:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4825B8FC17 for ; Mon, 26 Mar 2012 06:20:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2Q6K9pq018994 for ; Mon, 26 Mar 2012 06:20:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2Q6K9xq018993; Mon, 26 Mar 2012 06:20:09 GMT (envelope-from gnats) Resent-Date: Mon, 26 Mar 2012 06:20:09 GMT Resent-Message-Id: <201203260620.q2Q6K9xq018993@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Conrad J. Sabatier" Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6B5DB106566C for ; Mon, 26 Mar 2012 06:15:26 +0000 (UTC) (envelope-from conrads@serene.no-ip.org) Received: from eastrmfepo103.cox.net (eastrmfepo103.cox.net [68.230.241.215]) by mx1.freebsd.org (Postfix) with ESMTP id F37C98FC15 for ; Mon, 26 Mar 2012 06:15:25 +0000 (UTC) Received: from eastrmimpo209.cox.net ([68.230.241.224]) by eastrmfepo103.cox.net (InterMail vM.8.01.04.00 201-2260-137-20101110) with ESMTP id <20120326061514.SLJI8874.eastrmfepo103.cox.net@eastrmimpo209.cox.net> for ; Mon, 26 Mar 2012 02:15:14 -0400 Received: from serene.no-ip.org ([98.164.84.176]) by eastrmimpo209.cox.net with bizsmtp id q6F21i0033oG0Ji026F45W; Mon, 26 Mar 2012 02:15:14 -0400 Received: from serene.no-ip.org (localhost [127.0.0.1]) by serene.no-ip.org (8.14.5/8.14.5) with ESMTP id q2Q6F1Xa009930 for ; Mon, 26 Mar 2012 01:15:01 -0500 (CDT) (envelope-from conrads@serene.no-ip.org) Received: (from root@localhost) by serene.no-ip.org (8.14.5/8.14.5/Submit) id q2Q6EuJ5009929; Mon, 26 Mar 2012 01:14:56 -0500 (CDT) (envelope-from conrads) Message-Id: <201203260614.q2Q6EuJ5009929@serene.no-ip.org> Date: Mon, 26 Mar 2012 01:14:56 -0500 (CDT) From: "Conrad J. Sabatier" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/166404: [patch (resubmission)] src/usr.sbin/mptutil/mpt_show.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Conrad J. Sabatier" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2012 06:20:09 -0000 >Number: 166404 >Category: bin >Synopsis: [patch (resubmission)] src/usr.sbin/mptutil/mpt_show.c >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Mar 26 06:20:08 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Conrad J. Sabatier >Release: FreeBSD 10.0-CURRENT amd64 >Organization: >Environment: System: FreeBSD serene.no-ip.org 10.0-CURRENT FreeBSD 10.0-CURRENT #0: Sun Feb 12 19:15:46 CST 2012 conrads@serene.no-ip.org:/usr/obj/usr/src/sys/CUSTOM amd64 >Description: When building world with DEBUG defined, the build fails in the file "usr.sbin/mptutil/mpt_show.c" in function "show_physdisks()". This function is wrapped in an #idfef DEBUG conditional and so will not cause any problems when DEBUG is not defined, but when it is, an 'undefined identifier' error occurs due to there being no declaration for the variable 'error' (which *is* declared in other, similar functions which aren't DEBUG-dependent). I originally submitted this patch back in late January, but it seems to have somehow simply "fallen through the cracks". >How-To-Repeat: Define DEBUG on a buildworld. Sit back and wait for the inevitable. >Fix: patch below --- mptutil.diff begins here --- Index: src/usr.sbin/mptutil/mpt_show.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/mptutil/mpt_show.c,v retrieving revision 1.3 diff -u -r1.3 mpt_show.c --- src/usr.sbin/mptutil/mpt_show.c 9 Nov 2010 19:28:06 -0000 1.3 +++ src/usr.sbin/mptutil/mpt_show.c 31 Jan 2012 19:22:16 -0000 @@ -538,7 +538,7 @@ { CONFIG_PAGE_RAID_PHYS_DISK_0 *pinfo; U16 IOCStatus; - int fd, i; + int error, fd, i; if (ac != 1) { warnx("show drives: extra arguments"); --- mptutil.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: