Date: Mon, 26 Mar 2012 01:14:56 -0500 (CDT) From: "Conrad J. Sabatier" <conrads@cox.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/166404: [patch (resubmission)] src/usr.sbin/mptutil/mpt_show.c Message-ID: <201203260614.q2Q6EuJ5009929@serene.no-ip.org> Resent-Message-ID: <201203260620.q2Q6K9xq018993@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 166404
>Category: bin
>Synopsis: [patch (resubmission)] src/usr.sbin/mptutil/mpt_show.c
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Mar 26 06:20:08 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Conrad J. Sabatier
>Release: FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD serene.no-ip.org 10.0-CURRENT FreeBSD 10.0-CURRENT #0: Sun Feb 12 19:15:46 CST 2012 conrads@serene.no-ip.org:/usr/obj/usr/src/sys/CUSTOM amd64
>Description:
When building world with DEBUG defined, the build fails in the file
"usr.sbin/mptutil/mpt_show.c" in function "show_physdisks()". This
function is wrapped in an #idfef DEBUG conditional and so will not cause
any problems when DEBUG is not defined, but when it is, an 'undefined
identifier' error occurs due to there being no declaration for the
variable 'error' (which *is* declared in other, similar functions which
aren't DEBUG-dependent).
I originally submitted this patch back in late January, but it seems to
have somehow simply "fallen through the cracks".
>How-To-Repeat:
Define DEBUG on a buildworld. Sit back and wait for the inevitable.
>Fix:
patch below
--- mptutil.diff begins here ---
Index: src/usr.sbin/mptutil/mpt_show.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/mptutil/mpt_show.c,v
retrieving revision 1.3
diff -u -r1.3 mpt_show.c
--- src/usr.sbin/mptutil/mpt_show.c 9 Nov 2010 19:28:06 -0000 1.3
+++ src/usr.sbin/mptutil/mpt_show.c 31 Jan 2012 19:22:16 -0000
@@ -538,7 +538,7 @@
{
CONFIG_PAGE_RAID_PHYS_DISK_0 *pinfo;
U16 IOCStatus;
- int fd, i;
+ int error, fd, i;
if (ac != 1) {
warnx("show drives: extra arguments");
--- mptutil.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203260614.q2Q6EuJ5009929>