From owner-svn-src-head@FreeBSD.ORG  Tue Nov 27 09:59:16 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id E637B152;
 Tue, 27 Nov 2012 09:59:16 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 6FB228FC13;
 Tue, 27 Nov 2012 09:59:15 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA10777;
 Tue, 27 Nov 2012 11:59:07 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1TdHwZ-000NPL-Iv; Tue, 27 Nov 2012 11:59:07 +0200
Message-ID: <50B48EE9.1090506@FreeBSD.org>
Date: Tue, 27 Nov 2012 11:59:05 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: David Xu <davidxu@FreeBSD.org>
Subject: Re: svn commit: r243599 - head/sys/kern
References: <201211270607.qAR67w6O094153@svn.freebsd.org>
In-Reply-To: <201211270607.qAR67w6O094153@svn.freebsd.org>
X-Enigmail-Version: 1.4.6
Mail-Followup-To: David Xu <davidxu@FreeBSD.org>, 
 src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, 
 svn-src-head@FreeBSD.org, Konstantin Belousov <kib@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org, Konstantin Belousov <kib@FreeBSD.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Nov 2012 09:59:17 -0000

on 27/11/2012 08:07 David Xu said the following:
> Author: davidxu
> Date: Tue Nov 27 06:07:58 2012
> New Revision: 243599
> URL: http://svnweb.freebsd.org/changeset/base/243599
> 
> Log:
>   Take first active vnode correctly.
>   
>   Reviewed by:	kib
>   MFC after:	3 days
> 
> Modified:
>   head/sys/kern/vfs_subr.c
> 
> Modified: head/sys/kern/vfs_subr.c
> ==============================================================================
> --- head/sys/kern/vfs_subr.c	Tue Nov 27 06:01:02 2012	(r243598)
> +++ head/sys/kern/vfs_subr.c	Tue Nov 27 06:07:58 2012	(r243599)
> @@ -4755,7 +4755,7 @@ __mnt_vnode_first_active(struct vnode **
>  	MNT_REF(mp);
>  	(*mvp)->v_type = VMARKER;
>  
> -	vp = TAILQ_NEXT(*mvp, v_actfreelist);
> +	vp = TAILQ_FIRST(&mp->mnt_activevnodelist);
>  	while (vp != NULL) {
>  		VI_LOCK(vp);
>  		if (vp->v_mount == mp && vp->v_type != VMARKER &&
> 

Oh, wow, did this even work before?
Did it always just return NULL and no active list iteration happened?

-- 
Andriy Gapon