From owner-svn-src-head@FreeBSD.ORG  Mon Mar 14 18:34:16 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3AD751065756;
	Mon, 14 Mar 2011 18:34:16 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 0B18E8FC18;
	Mon, 14 Mar 2011 18:34:16 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 99E8746B8F;
	Mon, 14 Mar 2011 14:34:15 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.10])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 37BD18A01B;
	Mon, 14 Mar 2011 14:34:15 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Pawel Jakub Dawidek <pjd@freebsd.org>
Date: Mon, 14 Mar 2011 14:29:23 -0400
User-Agent: KMail/1.13.5 (FreeBSD/7.4-CBSD-20110107; KDE/4.4.5; amd64; ; )
References: <201102271941.p1RJfePI000348@svn.freebsd.org>
In-Reply-To: <201102271941.p1RJfePI000348@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201103141429.23954.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Mon, 14 Mar 2011 14:34:15 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r219089 - in head: cddl/compat/opensolaris/include
	cddl/compat/opensolaris/misc cddl/contrib/opensolaris/cmd/stat
	cddl/contrib/opensolaris/cmd/stat/common
	cddl/contrib/opensolaris/cmd/z...
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Mar 2011 18:34:16 -0000

On Sunday, February 27, 2011 2:41:40 pm Pawel Jakub Dawidek wrote:
> Author: pjd
> Date: Sun Feb 27 19:41:40 2011
> New Revision: 219089
> URL: http://svn.freebsd.org/changeset/base/219089
> 
> Log:
>   Finally... Import the latest open-source ZFS version - (SPA) 28.
>   
>   Few new things available from now on:
>   
>   - Data deduplication.
>   - Triple parity RAIDZ (RAIDZ3).
>   - zfs diff.
>   - zpool split.
>   - Snapshot holds.
>   - zpool import -F. Allows to rewind corrupted pool to earlier
>     transaction group.
>   - Possibility to import pool in read-only mode.
>   
>   MFC after:	1 month

Did you test non-GPT booting?  You updated BOOT2SIZE in its Makefile but 
ignored the comment:

# We currently allow 32768 bytes for zfsboot - in practice it could be
# any size up to 3.5Mb but keeping it fixed size simplifies zfsldr.
# 
BOOT2SIZE=	65536

If you want to use a larger size, you have to change zfsldr.S as it has a 
hardcoded sector count that it loads off of disk:

		.set NSECT,0x40
...

main.5: 	mov %dx,MEM_ARG			# Save args
		movb $NSECT,%dh			# Sector count
		movl $1024,%eax			# Offset to boot2
		callw nread.1			# Read disk

Since 0x40 * 512 = 32k, zfsldr.S is only going to load the first 32k of 
zfsboot into RAM.  If you need to bump this size up, you need to update the 
comment and NSECT in zfsldr.S.

-- 
John Baldwin