Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 May 2012 04:53:46 +0000 (UTC)
From:      Pyun YongHyeon <yongari@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r236219 - stable/8/sys/dev/bge
Message-ID:  <201205290453.q4T4rkHp053607@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: yongari
Date: Tue May 29 04:53:46 2012
New Revision: 236219
URL: http://svn.freebsd.org/changeset/base/236219

Log:
  MFC r235821:
    Don't force max payload size to 128. Root complex and Endpoint will
    negotiate with each other on the TLP payload size so blindly
    forcing the size to 128 can cause a completion error which in turn
    will stop device.
  
    Reported by:	Geans Pin < geanspin <> broadcom dot com >

Modified:
  stable/8/sys/dev/bge/if_bge.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/boot/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)
  stable/8/sys/dev/e1000/   (props changed)

Modified: stable/8/sys/dev/bge/if_bge.c
==============================================================================
--- stable/8/sys/dev/bge/if_bge.c	Tue May 29 04:44:51 2012	(r236218)
+++ stable/8/sys/dev/bge/if_bge.c	Tue May 29 04:53:46 2012	(r236219)
@@ -3663,8 +3663,6 @@ bge_reset(struct bge_softc *sc)
 		/* Clear enable no snoop and disable relaxed ordering. */
 		devctl &= ~(PCIM_EXP_CTL_RELAXED_ORD_ENABLE |
 		    PCIM_EXP_CTL_NOSNOOP_ENABLE);
-		/* Set PCIE max payload size to 128. */
-		devctl &= ~PCIM_EXP_CTL_MAX_PAYLOAD;
 		pci_write_config(dev, sc->bge_expcap + PCIR_EXPRESS_DEVICE_CTL,
 		    devctl, 2);
 		/* Clear error status. */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205290453.q4T4rkHp053607>