From owner-freebsd-current@FreeBSD.ORG  Wed Oct  8 12:15:06 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4823CF2E
 for <current@freebsd.org>; Wed,  8 Oct 2014 12:15:06 +0000 (UTC)
Received: from nibbler.fubar.geek.nz (nibbler.fubar.geek.nz [199.48.134.198])
 by mx1.freebsd.org (Postfix) with ESMTP id 2EFD87A0
 for <current@freebsd.org>; Wed,  8 Oct 2014 12:15:05 +0000 (UTC)
Received: from bender.lan (97e07ab1.skybroadband.com [151.224.122.177])
 by nibbler.fubar.geek.nz (Postfix) with ESMTPSA id B0CBE5C0B9
 for <current@freebsd.org>; Wed,  8 Oct 2014 12:15:02 +0000 (UTC)
Date: Wed, 8 Oct 2014 13:14:40 +0100
From: Andrew Turner <andrew@fubar.geek.nz>
To: current@freebsd.org
Subject: Floating-point review
Message-ID: <20141008131440.41b12409@bender.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Oct 2014 12:15:06 -0000

I'm looking for someone who known more about floating-point than I do
to review one of me changes. The change in question adds 6 new
functions to the ARM libc to perform floating-point comparisons. These
functions are required as part of the ABI spec.

The review is at [1]. I am mostly interested in having someone check
__aeabi_cfcmpeq_helper and __aeabi_cdcmpeq_helper are correct. They
should both return when either argument is a quiet NaN unless one is a
signalling NaN for floats and doubles respectively.

These functions are used by a functions that is defined to not raise a
floating point exception with comparing with quiet NaNs and all
comparisons with signalling NaNs could potentially raise an exception.
Because of this requirement these functions are used to filter out the
cases we have one or more quiet NaNs and no signalling NaNs.

Andrew

[1] https://reviews.freebsd.org/D872