From owner-freebsd-ports Sun Dec 16 18:45:27 2001 Delivered-To: freebsd-ports@freebsd.org Received: from mail.hiwaay.net (fly.HiWAAY.net [208.147.154.56]) by hub.freebsd.org (Postfix) with ESMTP id E5DCD37B416 for ; Sun, 16 Dec 2001 18:45:24 -0800 (PST) Received: from bsd.havk.org (user-24-214-88-13.knology.net [24.214.88.13]) by mail.hiwaay.net (8.12.1/8.12.1) with ESMTP id fBH2jLBZ010493; Sun, 16 Dec 2001 20:45:22 -0600 (CST) Received: by bsd.havk.org (Postfix, from userid 1001) id AAE421A786; Sun, 16 Dec 2001 20:45:20 -0600 (CST) Date: Sun, 16 Dec 2001 20:45:20 -0600 From: Steve Price To: Alan Eldridge Cc: freebsd-ports@FreeBSD.ORG Subject: Re: ports/32917: bsd.ports.mk fails for innocent $GREP_OPTIONS Message-ID: <20011216204520.J72144@bsd.havk.org> References: <200112170230.fBH2U1g08373@freefall.freebsd.org> <20011216213036.A70404@wwweasel.geeksrus.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011216213036.A70404@wwweasel.geeksrus.net>; from alane@geeksrus.net on Sun, Dec 16, 2001 at 09:30:36PM -0500 X-Operating-System: FreeBSD 4.4-STABLE i386 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sun, Dec 16, 2001 at 09:30:36PM -0500, Alan Eldridge wrote: > > Steve, I thought he was asking that it be added to the Makefile of the > port(s) that exhibited the problem, not to bsd.port.mk. He was just noting > that the breakage occurred in bsd.ports.mk. I understand that. However there are bound to be problems with his setting of GREP_OPTIONS in other ports as well. If setting GREP_OPTIONS='' in this port's Makefile fixes it then adding the this setting to /etc/make.conf will accomplish the same thing for all the other ports that would be broken by it. There are entirely too many programs out there that change their behavior based on the value of an environment variable. Finding every port that breaks for every permutation and fixing the port and/or changing bsd.port.mk is not the right solution IMHO. Forceably unsetting GREP_OPTIONS when it is '-Ei' might be the right thing for all ports but there's bound to be a setting where it isn't the right thing. If this person is having problems with his GREP_OPTIONS setting while building ports then he should either unset it while building ports or find a way like in /etc/make.conf that does it for him. -steve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message