From owner-p4-projects@FreeBSD.ORG  Sat Mar 27 23:22:15 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B23211065673; Sat, 27 Mar 2010 23:22:15 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7675D106566C
	for <perforce@freebsd.org>; Sat, 27 Mar 2010 23:22:15 +0000 (UTC)
	(envelope-from hselasky@freebsd.org)
Received: from swip.net (mailfe11.tele2.se [212.247.155.65])
	by mx1.freebsd.org (Postfix) with ESMTP id 032ED8FC12
	for <perforce@freebsd.org>; Sat, 27 Mar 2010 23:22:14 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=Nr52M_ujr-IA:10 a=8nJEP1OIZ-IA:10
	a=M8b_wTzEtboA:10 a=MnI1ikcADjEx7bvsp0jZvQ==:17
	a=6I5d2MoRAAAA:8 a=pXW_3JoJF4aKdTeZ5iUA:9
	a=TLCY_RM69KxE4P4imzwA:7 a=JKZQ6-Wf169epPc369c34nb2xwEA:4
	a=wPNLvfGTeEIA:10
Received: from [188.126.201.140] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe11.swip.net (CommuniGate Pro SMTP 5.2.19)
	with ESMTPA id 1212875409; Sat, 27 Mar 2010 23:22:11 +0100
Received-SPF: softfail receiver=mailfe11.swip.net; client-ip=188.126.201.140;
	envelope-from=hselasky@freebsd.org
From: Hans Petter Selasky <hselasky@freebsd.org>
To: Garrett Cooper <yanegomi@gmail.com>
Date: Sat, 27 Mar 2010 23:20:18 +0100
User-Agent: KMail/1.12.4 (FreeBSD/8.0-STABLE; KDE/4.3.4; amd64; ; )
References: <201003272109.o2RL9oCK000388@repoman.freebsd.org>
	<D853088A-3817-4EBE-9B94-F61276A71F2A@gmail.com>
In-Reply-To: <D853088A-3817-4EBE-9B94-F61276A71F2A@gmail.com>
X-Face: +~\`s("[*<S!NI[0M*"FaghA8S>|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'(; _IjlA:
	hGE..Ew, XAQ*o#\/M~SC=S1-f9{EzRfT'|Hhll5Q]ha5Bt-s|oTlKMusi:1e[wJl}kd}GR
	Z0adGx-x_0zGbZj'e(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L'
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201003272320.18961.hselasky@freebsd.org>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 176177 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Mar 2010 23:22:16 -0000

On Saturday 27 March 2010 23:18:20 Garrett Cooper wrote:
> On Mar 27, 2010, at 2:09 PM, Hans Petter Selasky wrote:
> > http://p4web.freebsd.org/chv.cgi?CH=176177
> >
> > Change 176177 by hselasky@hselasky_laptop001 on 2010/03/27 21:09:02
> >
> > 	USB input:
> > 		- fix wrongly swapping of keys on Apple keyboards.
> > 		- reported by: Steven Noonan
> >
> > Affected files ...
> >
> > .. //depot/projects/usb/src/sys/dev/usb/input/ukbd.c#48 edit
> >
> > Differences ...
> >
> > ==== //depot/projects/usb/src/sys/dev/usb/input/ukbd.c#48 (text+ko) ====
> >
> > @@ -896,8 +896,7 @@
> > 		    hid_input, 0, &sc->sc_loc_apple_fn, &flags,
> > 		    &temp_id)) {
> > 			if (flags & HIO_VARIABLE)
> > -				sc->sc_flags |= UKBD_FLAG_APPLE_FN |
> > -				    UKBD_FLAG_APPLE_SWAP;
> > +				sc->sc_flags |= UKBD_FLAG_APPLE_FN;
> > 			DPRINTFN(1, "Found Apple FN-key\n");
> > 			apple_keys = 1;
> > 			sc->sc_kbd_id = temp_id;
> 
> 	My apple keyboards work fine on FreeBSD (just not linux... hehe). What was
>  the full description of the problem here? Thanks,
> -Garrett
> 

See "usb/144414".

--HPS