From owner-freebsd-current@FreeBSD.ORG Sun Feb 26 12:40:05 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D0CD16A420 for ; Sun, 26 Feb 2006 12:40:05 +0000 (GMT) (envelope-from fli+freebsd-current@shapeshifter.se) Received: from mx1.h3q.net (manticore.shapeshifter.se [212.37.5.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B53143D48 for ; Sun, 26 Feb 2006 12:40:04 +0000 (GMT) (envelope-from fli+freebsd-current@shapeshifter.se) Received: from localhost (localhost [127.0.0.1]) by mx1.h3q.net (Postfix) with ESMTP id 5156F1A95E; Sun, 26 Feb 2006 13:40:02 +0100 (CET) Received: from mx1.h3q.net ([127.0.0.1]) by localhost (mx1.h3q.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 54577-02; Sun, 26 Feb 2006 13:40:00 +0100 (CET) Received: from [192.168.0.81] (81-234-243-91-o926.tbon.telia.com [81.234.243.91]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.h3q.net (Postfix) with ESMTP id 1908F1A6A8; Sun, 26 Feb 2006 13:39:59 +0100 (CET) Message-ID: <4401A199.4090102@shapeshifter.se> Date: Sun, 26 Feb 2006 13:39:53 +0100 From: Fredrik Lindberg User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050928) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ian Dowse References: <200602260310.aa36064@nowhere.iedowse.com> In-Reply-To: <200602260310.aa36064@nowhere.iedowse.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at h3q.net Cc: freebsd-current@freebsd.org Subject: Re: USB and clear endpoint stall X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Feb 2006 12:40:05 -0000 Ian Dowse wrote: > In message <200602191500.aa87886@nowhere.iedowse.com>, Ian Dowse writes: > >>In message <43F87155.3050103@shapeshifter.se>, Fredrik Lindberg writes: >> >>>I've attached a patch that works for me, it's basicly the same >>>as before Jan 8, but with the quirk reversed. >>>My USB-foo isn't that good so people with better understanding >>>of the USB stack might have a better fix for this. >> >>Committed, thanks! I wasn't sure if such devices would exist, but >>that's exactly the right way to handle them. > > > There was another issue found with removal of the stall-clearing > code, which was that data toggle values were not preserved if a > pipe was closed and then reopened. I wonder could you try updating > to the latest -current USB code but remove your quirk to see if it > is still necessary? > It appears to run just fine without the quirk now. So it's probably safe to back out the quirk, atleast for this device. Fredrik Lindberg