From owner-svn-ports-head@FreeBSD.ORG Sun Dec 21 19:56:53 2014 Return-Path: Delivered-To: svn-ports-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CBA80CEB; Sun, 21 Dec 2014 19:56:53 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A1C473E90; Sun, 21 Dec 2014 19:56:53 +0000 (UTC) Received: from [192.168.0.187] (75-173-123-43.albq.qwest.net [75.173.123.43]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by apnoea.adamw.org (Postfix) with ESMTPSA id 6596D1140AC; Sun, 21 Dec 2014 12:56:52 -0700 (MST) References: <201412201559.sBKFxl9d088764@svn.freebsd.org> <46210F48-0FE2-4B61-AA64-17472B9EAEEB@adamw.org> <549707F1.4070205@FreeBSD.org> <549722A1.8070104@FreeBSD.org> Mime-Version: 1.0 (1.0) In-Reply-To: <549722A1.8070104@FreeBSD.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: <0C87C52E-BBE7-4C2A-819F-AF150F5A5ECD@adamw.org> X-Mailer: iPad Mail (12B440) From: Adam Weinberger Subject: Re: svn commit: r375010 - head/Mk Date: Sun, 21 Dec 2014 12:56:54 -0700 To: Steve Wills Cc: "svn-ports-head@FreeBSD.org" , "svn-ports-all@FreeBSD.org" , "ports-committers@FreeBSD.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Dec 2014 19:56:53 -0000 > On Dec 21, 2014, at 12:42, Steve Wills wrote: >=20 >> On 12/21/14 19:28, Adam Weinberger wrote: >>=20 >>=20 >> Sure, same as other ports. Only difference is that, same as other >> ports, you don't need to come up with the commit SHA hash as well. >> You're portmgr, it's your call of course, I just thought it was a >> nice alternative for ports with release tarballs on github to use a >> simpler method. >=20 > I thought you were talking about ones that didn't use the GitHub release. >=20 > For ones that do use the GitHub release, making using those easier was > the goal of this commit. For example, after this commit, I can change > net/syncthing like so: >=20 > -MASTER_SITES=3D > https://github.com/${PORTNAME}/${PORTNAME}/archive/v${PORTVERSION}.tar.gz?= dummy=3D/ >=20 > +MASTER_SITES=3D GHR > +DISTVERSIONPREFIX=3D v > +USE_GITHUB=3D yes >=20 > No commit hash in either one. Also note there are some additional > changes for USE_GITHUB in the pipeline: >=20 > https://reviews.freebsd.org/D748 Oooh that's even better! I didn't pick that up when I saw the diff. Sorry ab= out the noise, I blame lack of coffee at the time. Can I suggest altering th= e PH or CHANGES to reflect the new behaviour? # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org