From owner-svn-src-all@freebsd.org Sat Feb 11 00:34:51 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7C74CDAE2F; Sat, 11 Feb 2017 00:34:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A4C521311; Sat, 11 Feb 2017 00:34:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 6C96D10A7B9; Fri, 10 Feb 2017 19:34:49 -0500 (EST) From: John Baldwin To: "Ngie Cooper (yaneurabeya)" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313564 - head/sys/kern Date: Fri, 10 Feb 2017 16:34:35 -0800 Message-ID: <123901029.nPdTysnfLg@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: References: <201702101925.v1AJPqhR022902@repo.freebsd.org> <2023305.EdEEquGYxm@ralph.baldwin.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Fri, 10 Feb 2017 19:34:49 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Feb 2017 00:34:52 -0000 On Friday, February 10, 2017 12:19:35 PM Ngie Cooper wrote: >=20 > > On Feb 10, 2017, at 11:38, John Baldwin wrote: > >=20 > > On Friday, February 10, 2017 07:25:52 PM John Baldwin wrote: > >> Author: jhb > >> Date: Fri Feb 10 19:25:52 2017 > >> New Revision: 313564 > >> URL: https://svnweb.freebsd.org/changeset/base/313564 > >>=20 > >> Log: > >> Drop the "created from" line from files generated by makesyscalls= .sh. > >>=20 > >> This information is less useful when the generated files are incl= uded in > >> source control along with the source. If needed it can be recons= tructed > >> from the $FreeBSD$ tag in the generated file. Removing this info= rmation > >> from the generated output permits committing the generated files = along > >> with the change to the system call master list without having inc= onsistent > >> metadata in the generated files. > >=20 > > There is a tradeoff of course. Having the generated files mixed in= the > > commits does make the diff more noisy, and it can be more of a pain= in reviews. > > One can still just not include the generated files when posting rev= iews (we > > already have to do that because you have to generate the files to d= o testing). > >=20 > > However, I do think that at least for MFCs we should include the ge= nerated > > files in the merge so that on stable branches we don't have known-b= roken > > commits once this change is merged back to stable branches. >=20 > Uhh=E2=80=A6. $FreeBSD$ isn=E2=80=99t being expanded in some of these= files=E2=80=A6 >=20 > $ svn pg svn:keywords sys/sys/syscall.mk > FreeBSD=3D%H > $ grep '$FreeBSD' sys/sys/syscall.mk > # $FreeBSD$ Which client are you using? This is what I see on the clean checkout of head I comitted this from: % grep FreeBSD sys/sys/syscall.mk # FreeBSD system call object files. # $FreeBSD: head/sys/sys/syscall.mk 313566 2017-02-10 19:45:02Z jhb $ --=20 John Baldwin