From owner-cvs-all@FreeBSD.ORG Mon Jun 14 03:59:41 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 9030216A4CE; Mon, 14 Jun 2004 03:59:41 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.12.11/8.12.11) with ESMTP id i5E3xfi4049750; Sun, 13 Jun 2004 23:59:41 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.12.11/8.12.11/Submit) id i5E3xehj049749; Sun, 13 Jun 2004 23:59:40 -0400 (EDT) (envelope-from green) Date: Sun, 13 Jun 2004 23:59:40 -0400 From: Brian Feldman To: Marius Strobl Message-ID: <20040614035939.GC39574@green.homeunix.org> References: <200406131501.i5DF1Sqm065546@repoman.freebsd.org> <20040614021442.GB39574@green.homeunix.org> <20040614052835.I1600@newtrinity.zeist.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040614052835.I1600@newtrinity.zeist.de> User-Agent: Mutt/1.5.6i cc: Alexander Leidinger cc: cvs-all@freebsd.org cc: ports-committers@freebsd.org Subject: Re: cvs commit: ports/sysutils/cdrdao Makefile distinfo ports/sysutils/cdrdao/files patch-Makefile.in patch-configure patch-dao::ScsiIf-lib.cc patch-dao::cdrdao.drivers patch-dao::dao.cc patch-paranoia::isort.c patch-trackdb::Track.cc patch-trackdb::lec.cc ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2004 03:59:42 -0000 On Mon, Jun 14, 2004 at 05:28:35AM +0200, Marius Strobl wrote: > On Sun, Jun 13, 2004 at 10:14:42PM -0400, Brian Feldman wrote: > > On Sun, Jun 13, 2004 at 03:01:28PM +0000, Alexander Leidinger wrote: > > > - Disable the use of mlockall(2) on FreeBSD 5, even after the last round > > > of fixes there are still issues. > > > > What are you referring to? The issues that are still there should not > > affect simple mlockall(2) usage. > > > > - On i386, depending on the program, mlockall() always returns EAGAIN. > E.g. ntpd of the net/ntp port exhibits this problem. This isn't an > issue with cdrdao. > - On sparc64, every call of mlockall(MCL_CURRENT) returns EAGAIN, even > in a program just doing that. Yes, there is a problem with mlockall(2), especially with NTPD: if the VM space has areas that have no read protection, i.e. PROT_NONElike NTPD is mapping for some reason, it will fail in this manner. There are several possible ways to fix this (one of which I've implemented); Alan Cox's suggestion to pretend PROT_NONE is PROT_READ when wiring is much simpler to implement. Could you cat a /proc/curproc/map from the current running process on sparc64 after mlockall(2) fails? > Don't know about the other architectures. So there is no technical > reason to not to use mlockall() as it no longer seems to have side > effects (at least not on i386 and sparc64) like random processes > crashing when another one uses it or causing panics like it did in > the beginning. But I don't want to frighten the users of a port > with the warnings that the failing mlockall() causes, especially > if it is a verbose one like that of cdrecord. I think it's best to enable mlockall(2) like the software creators intended and let their documentation handle any confusion by the user. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\