From nobody Fri Apr 12 20:03:29 2024 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VGSDj3RKqz5G1fW for ; Fri, 12 Apr 2024 20:03:33 +0000 (UTC) (envelope-from matthew@matthewphillips.info) Received: from wfout3-smtp.messagingengine.com (wfout3-smtp.messagingengine.com [64.147.123.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4VGSDj1txfz4ZCr; Fri, 12 Apr 2024 20:03:33 +0000 (UTC) (envelope-from matthew@matthewphillips.info) Authentication-Results: mx1.freebsd.org; none Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.west.internal (Postfix) with ESMTP id AAEE71C00084; Fri, 12 Apr 2024 16:03:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 12 Apr 2024 16:03:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= matthewphillips.info; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1712952211; x=1713038611; bh=kZg5SevF1N HspikxZpQbIxPyU49ZS5edQ/+iKvh9qRU=; b=kP50ezp3xU3nHKRLQZFv6cCNEo M1imeezh5YcKF4ubNQjWL8oJSoGoduq0jqLikfkSZpYVXjgh0uV+5fBUsZgnhJ9t YLMWK7WtcCByIWGEyfrcJQjTYv1kwJn3sWl7E7T1RRzqtph4k9BrW9Rx1DnsXgTv 03aL/fEd7RZaLDr31EcALv1JAgCijr2n44wI7dt4Eva5UL8QwYlBT3WCy3E98CjA hcigatI1N2c3gmL/LleNZ4KitFq6GgWTGCk6Dk/gtZDI6+sKlPhuPo8R2s/mmCAM 3eSQv/QtcyDM2IuxX1Y94H5zF/tYGDKBHXihSB3AxRdSxqgpvZtJPxizq+IQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712952211; x= 1713038611; bh=kZg5SevF1NHspikxZpQbIxPyU49ZS5edQ/+iKvh9qRU=; b=C Ru/W4cXeuyaH+qmweu6PbXHkdSrIMijpExqtPQiI55jVGHbGHvowvgce91Kj+1j3 Ha/OoRVKKGJrjibZeIXNrPgyGndRDix5QBv/PhCxSZJo0bWwVwGG4ZobAnpCuRsn zlGu5R8eYW39Kh5bKnHj64Rp0CHswkHrMYAFQwOE7u/Vz585/dK5lBj8eXKRZYjQ 8F0z4wqJHmwOdngKaSLKhgA79nkZMXAkFck4rxS6qv8k4dTdauYijbB++q4Tay5C J6e6sx7yRpKlYrmFzYdCClfyfFpgTAHH73jAp012ISu7Ui9wiFHzcMrpVzOqfEMF p88BhiaKbsSgJ6FZQIGyA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudeiuddgudegiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtugfgjgestheksfdttddtudenucfhrhhomhepofgr thhthhgvficurfhhihhllhhiphhsuceomhgrthhthhgvfiesmhgrthhthhgvfihphhhilh hlihhpshdrihhnfhhoqeenucggtffrrghtthgvrhhnpeevjeefhfduvdejvdetgfegjedv iedugffflefgheetjeelgeduledviefhieffgfenucffohhmrghinhepihhtshgvlhhfrd htohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm rghtthhhvgifsehmrghtthhhvgifphhhihhllhhiphhsrdhinhhfoh X-ME-Proxy: Feedback-ID: i4e5840b4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Apr 2024 16:03:30 -0400 (EDT) Date: Fri, 12 Apr 2024 16:03:29 -0400 From: Matthew Phillips To: Chris Cc: Dag-Erling =?utf-8?B?U23DuHJncmF2?= , Kurt Hackenberg , ports@freebsd.org Subject: Re: Confused by what make package should do Message-ID: References: <43xrg75pzztfrhlszhekdlfqyiqfmbkgimfdjosrjbbr4sjzfq@fnyqc35f6zyw> <76c14675-a782-49cc-8d61-ff96eaab83c8@panix.com> <86mspycrax.fsf@ltc.des.dev> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29838, ipnet:64.147.123.0/24, country:US] X-Rspamd-Queue-Id: 4VGSDj1txfz4ZCr On Fri, Apr 12, 2024 at 12:57:41PM -0700, Chris wrote: > On 2024-04-12 12:50, Matthew Phillips wrote: > > On Fri, Apr 12, 2024 at 09:30:14PM +0200, Dag-Erling Smørgrav wrote: > > > Kurt Hackenberg writes: > > > > Matthew Phillips writes: > > > > > It's trying to install the port itself. To /usr/local/bin specifically. > > > > > It seems like it's running `make install` on the ports Makefile. > > > > From man ports(7): "package Make a binary package for the port. The > > > > port will be installed if it has not already been." > > > > > > This is both true, in that the `package` target implies the `stage` > > > target with does run `make install` in $WRKSRC, and highly misleading, > > > because the `stage` target does not install the port to your machine, > > > which would require superuser privileges, but to a staging directory, > > > which does not. The `install` target, which implies the `package` > > > target, uses `pkg add` to install the package to your machine. > > > > Thank you! This is the missing piece I didn't understand. It's starting > > to come together for me. > > > > So now I think it's a problem with the port's Makefile `install` target. > > The install target does this: > > > > install -m 755 snac $(PREFIX)/bin/snac > > > > So I think what I need to do is patch the Makefile to include DESTDIR > > like so: > > > > install -m 755 snac $(DESTDIR)$(PREFIX)/bin/snac > Those should be curly braces, not parentheses, fe; > ${DESTDIR} This is inside of the project's Makefile, not the port Makefile. I'm patching it to account for DESTDIR because PREFIX is /usr/local.