From owner-svn-src-head@FreeBSD.ORG Mon Mar 19 15:42:12 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 073C21065677 for ; Mon, 19 Mar 2012 15:42:12 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 79D028FC17 for ; Mon, 19 Mar 2012 15:42:10 +0000 (UTC) Received: by wern13 with SMTP id n13so7866883wer.13 for ; Mon, 19 Mar 2012 08:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=0vE/Phl6K0dlWa60orJhCXmigQDHsGfetH5poGv/t5I=; b=BL4wQnmPxMynfecxLmy7f4ghZFSnuaGNapykU5jF26AwnyNHbYIznLbTiw7ZDRnXLS 1Frwwmj1Vu0PmA+AQ4G8ETh3ftBLCT1ai1mpoyumOhftO/YTTFOm+yBijbG/qbb5vjOL PnxuS3nkyHaSY4GzUJCSM9p0vyAnJb4jXI46A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding:x-gm-message-state; bh=0vE/Phl6K0dlWa60orJhCXmigQDHsGfetH5poGv/t5I=; b=SxzEoJkkqTZw3Ka6Wg6F8YOLymJVSXEDtNhSRRUJxDUBq3NzDOAgFP3WcyMfPA2ewt fwpaQhSjrbroBfWcyw5IOWS6m3Ry2eW3SkA0IKWadnyCezlbECKbKpVe+7WW1E4hRWK5 Pg6+bB64ZMPhnH1GDHHiKnyq8y9BzenCbpnxGRnD1Xaj4TWZi2fMzdJC7pL5b8ihHKea qBQNBOD1MPv8uGj485PPYHcM16iVovfTC0faDtK5PO5s2vA4qQb2c0+cl2HSHJ3hTnMN rat5ZWHEEQH2YQzb8E7MV1PKINl8KyEN7kGrKeBGNttBGrw2UKIRgmqPTcfaJFP89XXM balQ== Received: by 10.180.84.164 with SMTP id a4mr20948307wiz.2.1332171724331; Mon, 19 Mar 2012 08:42:04 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.223.63.4 with HTTP; Mon, 19 Mar 2012 08:41:34 -0700 (PDT) In-Reply-To: <201203190835.27561.jhb@freebsd.org> References: <201203190041.q2J0femX042684@svn.freebsd.org> <201203190835.27561.jhb@freebsd.org> From: Eitan Adler Date: Mon, 19 Mar 2012 11:41:34 -0400 X-Google-Sender-Auth: pH5wJRfBt4nO1qhLN_8reYiq9Eg Message-ID: To: John Baldwin Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQnC7dwALSecfkCrsFKAa02sFmMWvQVo552oRl08tfIexroqsS2yfZJPoNkHjk6ZLbMCBd94 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233136 - in head/secure: usr.bin/ssh usr.sbin/sshd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Mar 2012 15:42:12 -0000 On Mon, Mar 19, 2012 at 8:35 AM, John Baldwin wrote: > On Sunday, March 18, 2012 8:41:40 pm Eitan Adler wrote: >> Author: eadler >> Date: Mon Mar 19 00:41:40 2012 >> New Revision: 233136 >> URL: http://svn.freebsd.org/changeset/base/233136 >> >> Log: >> =C2=A0 X11BASE is not used any more and has been killed by the x11 team. >> >> =C2=A0 Reviewed by: =C2=A0 =C2=A0 =C2=A0 =C2=A0??? >> =C2=A0 Approved by: =C2=A0 =C2=A0 =C2=A0 =C2=A0??? >> =C2=A0 MFC after: =C2=A03 days >> >> Modified: >> =C2=A0 head/secure/usr.bin/ssh/Makefile >> =C2=A0 head/secure/usr.sbin/sshd/Makefile > > This looks wrong. =C2=A0While X11BASE is certainly dead, LOCALBASE is not= , so the > existing code should have been changed, but not removed. =C2=A0Something = like this: > > .if defined(LOCALBASE) > CFLAGS+=3D -DXAUTH_PATH=3D\"${LOCALBASE}/bin/xauth\" > .endif I think I missed "X11BASE?=3D${LOCALBASE}" in the original code making me believe this change was a no-op. I'll have a patch to fix this soon. --=20 Eitan Adler Source & Ports committer X11, Bugbusting teams