From owner-freebsd-stable@FreeBSD.ORG Sat Jun 5 11:21:37 2004 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 76C5816A4CE for ; Sat, 5 Jun 2004 11:21:37 -0700 (PDT) Received: from mxsf01.cluster1.charter.net (mxsf01.cluster1.charter.net [209.225.28.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B1A743D1F for ; Sat, 5 Jun 2004 11:21:37 -0700 (PDT) (envelope-from archie@dellroad.org) Received: from InterJet.dellroad.org (cable-24-196-25-11.mtv.al.charter.com [24.196.25.11])i55I07Di047213; Sat, 5 Jun 2004 14:00:18 -0400 (EDT) Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.2.2.20]) by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id MAA84838; Sat, 5 Jun 2004 12:47:13 -0500 (CDT) Received: from arch20m.dellroad.org (localhost [127.0.0.1]) i55HlCKt001237; Sat, 5 Jun 2004 12:47:13 -0500 (CDT) (envelope-from archie@arch20m.dellroad.org) Received: (from archie@localhost) by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i55HlCr4001236; Sat, 5 Jun 2004 12:47:12 -0500 (CDT) (envelope-from archie) From: Archie Cobbs Message-Id: <200406051747.i55HlCr4001236@arch20m.dellroad.org> In-Reply-To: <20040604232523.A22373@das.ufsc.br> To: Rafael R Obelheiro Date: Sat, 5 Jun 2004 12:47:12 -0500 (CDT) X-Mailer: ELM [version 2.4ME+ PL99b (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII cc: freebsd-stable@FreeBSD.ORG cc: Rob Clark cc: acardenas@bsdperu.org Subject: Re: 4.10-STABLE - ADSL PPPoE X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jun 2004 18:21:37 -0000 Rafael R Obelheiro wrote: > > > > I update my system 4.10-STABLE(27 May) to FreeBSD > > > > 4.10-STABLE(June 2) without problems but now my > > > > connection ADSL does not work , previously worked > > > > correctly, and the connections with loopback 127.0.0.1 > > > > delay much, example ssh/ftp/ 127.0.0.1 delay 30 - 40 > > > > seconds. > > > > > > > I seen this same behavior today (06.03.04) after updating > > > sources. My last update was 05.27.04 and everything worked > > > fine at that point in the branch. > > > > > > > Apologies for following up on my own post, but i've narrowed > > down the failure window a bit. > > > > Edit src/sys/netgraph/ng_ether.c > > Add delta 1.2.2.15 2004.06.01.22.55.24 archie > > This is the culprit. I was having the same problem (PPPoE stopped Oops, my apologies.. I incorrectly applied the MFC. Please try the patch below (apply to the newer version of ng_ether.c) and let me know if this makes things work again. Thanks, -Archie __________________________________________________________________________ Archie Cobbs * CTO, Awarix * http://www.awarix.com --- ng_ether.c.orig Sat Jun 5 12:45:04 2004 +++ ng_ether.c Sat Jun 5 12:45:35 2004 @@ -89,7 +89,7 @@ static void ng_ether_detach(struct ifnet *ifp); /* Other functions */ -static void ng_ether_input2(node_p node, +static void ng_ether_input2(hook_p hook, struct mbuf **mp, struct ether_header *eh); static int ng_ether_glueback_header(struct mbuf **mp, struct ether_header *eh); @@ -203,7 +203,7 @@ /* If "lower" hook not connected, let packet continue */ if (priv->lower == NULL) return; - ng_ether_input2(node, mp, eh); + ng_ether_input2(priv->lower, mp, eh); } /* @@ -224,7 +224,7 @@ m_freem(m); return; } - ng_ether_input2(node, &m, eh); + ng_ether_input2(priv->orphan, &m, eh); if (m != NULL) m_freem(m); } @@ -237,9 +237,9 @@ * NOTE: this function will get called at splimp() */ static void -ng_ether_input2(node_p node, struct mbuf **mp, struct ether_header *eh) +ng_ether_input2(hook_p hook, struct mbuf **mp, struct ether_header *eh) { - const priv_p priv = node->private; + const priv_p priv = hook->node->private; meta_p meta = NULL; int error; @@ -248,7 +248,7 @@ return; /* Send out lower/orphan hook */ - (void)ng_queue_data(priv->lower, *mp, meta); + (void)ng_queue_data(hook, *mp, meta); *mp = NULL; }