From owner-p4-projects@FreeBSD.ORG  Mon Jul 10 17:03:16 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5960F16A4FB; Mon, 10 Jul 2006 17:03:16 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 08D1B16A4F4;
	Mon, 10 Jul 2006 17:03:16 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3442343D46;
	Mon, 10 Jul 2006 17:03:15 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k6AH39gX062835;
	Mon, 10 Jul 2006 13:03:14 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Oleksandr Tymoshenko <gonzo@freebsd.org>
Date: Mon, 10 Jul 2006 12:23:50 -0400
User-Agent: KMail/1.9.1
References: <200607101131.k6ABV6IS057848@repoman.freebsd.org>
In-Reply-To: <200607101131.k6ABV6IS057848@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200607101223.51217.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Mon, 10 Jul 2006 13:03:14 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.87.1/1590/Mon Jul 10 01:34:09 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 
	autolearn=ham version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 101195 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Jul 2006 17:03:16 -0000

On Monday 10 July 2006 07:31, Oleksandr Tymoshenko wrote:
> http://perforce.freebsd.org/chv.cgi?CH=101195
> 
> Change 101195 by gonzo@gonzo_hq on 2006/07/10 11:30:52
> 
> 	o Add mips-specific fields to mdthread struct.
> 
> Affected files ...
> 
> .. //depot/projects/mips2/src/sys/mips/include/proc.h#2 edit
> 
> Differences ...
> 
> ==== //depot/projects/mips2/src/sys/mips/include/proc.h#2 (text+ko) ====
> 
> @@ -37,8 +37,9 @@
>   * Machine-dependent part of the proc structure for AMD64.
>   */
>  struct mdthread {
> -	int	md_spinlock_count;	/* (k) */
> -	register_t md_saved_flags;	/* (k) */
> +	__register_t md_savecrit;	/* critical section saved SR */
> +	void	*md_regs;		/* registers on current frame */
> +	int	md_flags;		/* machine-dependent flags */
>  };

You will still need md_spinlock_count, and please call md_savecrit something 
better like 'md_saved_sr'.  The reason for this is that spinlock_enter/exit 
were added more recently than juli's work.

-- 
John Baldwin